From: Eli Zaretskii <eliz@gnu.org>
To: j0.kim@samsung.com
Cc: gdb-patches@sourceware.org
Subject: Re: [patch]change dwarf2_start_subfile() to adapt inappropriate dir name
Date: Mon, 15 Nov 2010 04:09:00 -0000 [thread overview]
Message-ID: <83oc9rcjps.fsf@gnu.org> (raw)
In-Reply-To: <19193243.6341289784074300.JavaMail.weblogic@epml17>
> Date: Mon, 15 Nov 2010 01:21:14 +0000 (GMT)
> From: JuYoung Kim <j0.kim@samsung.com>
> Cc: ê¹€ì£¼ì˜ <j0.kim@samsung.com>
>
> Â Â if (!IS_ABSOLUTE_PATH (filename) && dirname != NULL) {
> Â Â Â if (dirname[strlen(dirname)-1] == '/' || dirname[strlen(dirname)-1] == '')
Please use IS_DIR_SEPARATOR instead of testing for '/' literally. And
the second part of the if clause cannot happen at all, so it should be
removed.
Also, the GNU coding standards say to put the braces like this:
if (something)
{
do_something;
do_something_else;
}
> Â Â Â else fullname = concat (dirname, SLASH_STRING, filename, (char *)NULL);
Make "else" have its own line, like this:
else
fullname = concat (dirname, SLASH_STRING, filename, NULL);
next prev parent reply other threads:[~2010-11-15 4:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 1:21 JuYoung Kim
2010-11-15 4:09 ` Eli Zaretskii [this message]
2010-11-15 6:25 JuYoung Kim
2010-11-15 16:58 ` Joel Brobecker
2010-11-15 18:05 ` Nathan Froyd
2010-11-15 18:34 ` Eli Zaretskii
2010-11-23 20:47 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83oc9rcjps.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=j0.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).