From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=iEgg=CC=gnu.org=eliz@sourceware.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
	by sourceware.org (Postfix) with ESMTPS id 996103858D1E
	for <gdb-patches@sourceware.org>; Wed, 14 Jun 2023 11:43:42 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 996103858D1E
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e])
	by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.90_1)
	(envelope-from <eliz@gnu.org>)
	id 1q9Oub-0005vE-Bx; Wed, 14 Jun 2023 07:43:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
	s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
	mime-version; bh=G/EiDzbuaKdonK1k0LC4jPg4w3aKd0DyV9UX/ozvalY=; b=M1wN01RwzcNl
	ruYwjIqlDUapAAdAW9svcO5BMY+xWb2ThLxVCEDRrGtaouhDUujcbRmYCBlEfzx341ACitJ/ilUV5
	E4WP4yZb6BiYuKjG37nkOnKz5MN9MNFMNHmEqj7ufFtv+rMCIjfu6MCXMZgRFAjI11cf0Y9RjVO2B
	MhPLgnF4wctXQwWqPLjto6M/QiXvnLOW1UD1v6VKjj0L6F3e3i508c/++4mzwJbKGWCiCCNE5bhz2
	mCCs8ouA/d6eWO/TuCODLtawpXAjXuSSPVZxR/nH5+8Udn7pQP6oPyA1pXTrso4imm4fhIQXjSssb
	UayJ93MjgkkI9VQYsysyKg==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.90_1)
	(envelope-from <eliz@gnu.org>)
	id 1q9Oua-0003uU-Md; Wed, 14 Jun 2023 07:43:41 -0400
Date: Wed, 14 Jun 2023 14:43:59 +0300
Message-Id: <83pm5yuv40.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Simon Farre <simon.farre.cx@gmail.com>
Cc: gdb-patches@sourceware.org, tom@tromey.com
In-Reply-To: <20230614103327.30289-1-simon.farre.cx@gmail.com> (message from
	Simon Farre via Gdb-patches on Wed, 14 Jun 2023 12:33:27 +0200)
Subject: Re: [PATCH v1] gdb/dap - dataBreakpointInfo & setDataBreakpoints
References: <20230614103327.30289-1-simon.farre.cx@gmail.com>
X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

> Cc: tom@tromey.com,
> 	Simon Farre <simon.farre.cx@gmail.com>
> Date: Wed, 14 Jun 2023 12:33:27 +0200
> From: Simon Farre via Gdb-patches <gdb-patches@sourceware.org>
> 
> This is v1 of the implementation of these two requests.

I didn't (and cannot) review this in a useful way, but my eye caught a
few nits:

> -    if bp.locations:
> +    if bp.location is not None:
>          # Just choose the first location, because DAP doesn't allow
>          # multiple locations.  See
>          # https://github.com/microsoft/debug-adapter-protocol/issues/13
> +        # FIXME this does not matter; GDB can translate it's understanding
                                                           ^^^^
"its"

> +    # frameId does not have an effect when var ref is not none,
                                                             ^^^^
"None", capitalized?

> +    # however, frameId really never has an effect. An issue has been filed:
                                                    ^^
Two spaces there.

> +    # We've resolved the "path" for the variable using varrefs. Construct it
                                                                 ^^
And there.

> +    # Delete wps that are not found in `breakpoints` request
                                          ^^^^^^^^^^^^^
Are we okay with MD-style markup?

Thanks.