From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 1540A3858D32 for ; Mon, 27 Feb 2023 19:54:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1540A3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWjZU-000827-4Z; Mon, 27 Feb 2023 14:54:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NhEArnhYQwpD8kvh1gBuCoVyTpRB71iwI3Wr7vLWfzA=; b=KaaRuem2wDyr jUaobqT8ilS9kFkZwAp+Gcy5opY5vqWSsDBMnQkX5iMR/gz+kimKwARRDAtafJJ4JU8FtMKI06K5O m5sHx6fH0n8/QckT2uKAiuIeXxgrZnJPcZnYhYrUztW8wy4vJEIuCZ9jYg7ma0S0zGFjIt3E17B6t 3SrYLMhd8fReRde0pqDZW0uXrm0VJmD+L+c/6bejRuHULb+mMYp139DGOUAQCgfDNNWba7IxjAVNc TNnk3ac2mnSZQeB1RBegm0ZG++Blz20pWNq4jEfWg+CWO4bD8OMseGx4z+LUmn5PDwmuDnwE576/g dQdhWMvjzW6VMHEpzOikwQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWjZO-0007pf-EG; Mon, 27 Feb 2023 14:53:59 -0500 Date: Mon, 27 Feb 2023 21:54:06 +0200 Message-Id: <83pm9uhokh.fsf@gnu.org> From: Eli Zaretskii To: Aaron Merey Cc: gdb-patches@sourceware.org In-Reply-To: <20230227194212.348003-2-amerey@redhat.com> (message from Aaron Merey via Gdb-patches on Mon, 27 Feb 2023 14:42:07 -0500) Subject: Re: [PATCH 2/7] gdb: add 'lazy' setting for command 'set debuginfod enabled' References: <20230227194212.348003-1-amerey@redhat.com> <20230227194212.348003-2-amerey@redhat.com> X-Spam-Status: No, score=1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: Aaron Merey > Date: Mon, 27 Feb 2023 14:42:07 -0500 > From: Aaron Merey via Gdb-patches > > 'set debuginfod enabled lazy' turns on debuginfod downloading like > 'set debuginfod enabled on' but also enables ELF/DWARFs section > downloading via debuginfod_section_query. > > If support for debuginfod section queries was not found at configure > time, 'set debuginfod enabled lazy' will print an error message > indicating the missing support and default to 'set debuginfod enabled on'. > > Also update the help text and gdb.texinfo section for 'set debuginfod enabled' > with information on the lazy setting. > --- > gdb/debuginfod-support.c | 20 +++++++++++++++++--- > gdb/doc/gdb.texinfo | 9 +++++++-- > 2 files changed, 24 insertions(+), 5 deletions(-) Thanks. > @@ -550,8 +560,12 @@ _initialize_debuginfod () > _("Set whether to use debuginfod."), > _("Show whether to use debuginfod."), > _("\ > -When on, enable the use of debuginfod to download missing debug info and\n\ > -source files."), > +When set to \"on\", enable the use of debuginfod to download missing\n\ > +debug info and source files. \"off\" disables the use of debuginfod.\n\ > +When set to \"ask\", a prompt may ask whether to enable or disable\n\ > +debuginfod. When set to \"lazy\", debug info downloading will be\n\ > +deferred until it is required. GDB may also download components of\n\ ^^ Two spaces there. > +@item set debuginfod enabled lazy > +@value{GDBN} will attempt to defer downloading entire debug info files until > +necessary. @value{GDBN} may instead download individual components of the ^^ And there. Reviewed-By: Eli Zaretskii