From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92]) by sourceware.org (Postfix) with ESMTPS id BA1A73858C50 for ; Tue, 29 Mar 2022 13:48:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BA1A73858C50 Received: from [2001:470:142:3::e] (port=35978 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZCDP-0007fL-BQ; Tue, 29 Mar 2022 09:48:55 -0400 Received: from [87.69.77.57] (port=3544 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZCDK-0002Is-IM; Tue, 29 Mar 2022 09:48:55 -0400 Date: Tue, 29 Mar 2022 16:48:56 +0300 Message-Id: <83pmm498dz.fsf@gnu.org> From: Eli Zaretskii To: Christina Schimpe Cc: gdb-patches@sourceware.org In-Reply-To: <20220329131158.3970228-3-christina.schimpe@intel.com> (message from Christina Schimpe via Gdb-patches on Tue, 29 Mar 2022 15:11:57 +0200) Subject: Re: [PATCH v2 2/3] gdb: Add per-remote target variables for memory read and write config References: <20220329131158.3970228-1-christina.schimpe@intel.com> <20220329131158.3970228-3-christina.schimpe@intel.com> X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Mar 2022 13:48:57 -0000 > Date: Tue, 29 Mar 2022 15:11:57 +0200 > From: Christina Schimpe via Gdb-patches > > diff --git a/gdb/NEWS b/gdb/NEWS > index 7740162d3e..aa704d076d 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -16,6 +16,18 @@ > the configuration of the currently selected target. If no remote target is > selected, the default configuration for future connections is shown. > > + The individual packet sizes can be configured and shown using the commands > + ** 'set remote memory-read-packet-size (number of bytes|fixed|limit)' > + ** 'set remote memory-write-packet-size (number of bytes|fixed|limit)' > + ** 'show remote memory-read-packet-size' > + ** 'show remote memory-write-packet-size'. > + > + The configuration of the packet itself, as well as the size of a memory-read > + or memory-write packet, applies to the currently selected target (if > + available) and future remote connections. The "show remote" commands print > + the configuration of the currently selected target. If no remote target is > + selected, the default configuration for future connections is shown. > + > * GDB now supports hardware watchpoints on FreeBSD/Aarch64. > > * Remove support for building against Python 2, it is now only possible to This part of the patch is OK. > +@cindex Configuration of the remote packet size Index entries should all begin with a lower-case letter, so that their sorting (when the Info manual is produced) is not affected by the current locale. The documentation parts of the patch are okay with the above not fixed. Thanks.