public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: tromey@sourceware.org, gdb-patches@sourceware.org
Cc: gdb-patches@sourceware.org
Subject: Re: [review] Allow using less horizontal space in TUI source window
Date: Thu, 14 Nov 2019 09:55:00 -0000	[thread overview]
Message-ID: <83pnhu7peu.fsf@gnu.org> (raw)
In-Reply-To: <gerrit.1573404038000.I46ce9a68b12c9c79332d510f9c14b3c84b7efadd@gnutoolchain-gerrit.osci.io>

> Date: Sun, 10 Nov 2019 11:40:39 -0500
> From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
> 
> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/605
> ......................................................................
> 
> Allow using less horizontal space in TUI source window
> 
> The source window currently uses a field width of 6 for line numbers,
> and it further aligns to the next tab stop.  This seemed a bit
> wasteful of horizontal space to me, so I changed that in an earlier
> patch.
> 
> However, that change wasn't universally popular.  This patch instead
> adds the option to use less horizontal space in the TUI source window.
> 
> gdb/ChangeLog
> 2019-11-10  Tom Tromey  <tom@tromey.com>
> 
> 	* tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
> 	parameter.
> 	* tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
> 	parameter.
> 	* tui/tui-win.h (compact_source): Declare.
> 	* tui/tui-win.c (compact_source): New global.
> 	(tui_set_compact_source, tui_show_compact_source): New functions.
> 	(_initialize_tui_win): Add "compact-source" setting.
> 	* tui/tui-source.c (tui_source_window::set_contents): Handle
> 	compact_source setting.
> 	* tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
> 	* NEWS: Document new setting.
> 
> gdb/doc/ChangeLog
> 2019-11-10  Tom Tromey  <tom@tromey.com>
> 
> 	* gdb.texinfo (TUI Configuration): Document new setting.

OK for the documentation parts.

Thanks.

  parent reply	other threads:[~2019-11-14  9:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-10 16:40 Tom Tromey (Code Review)
2019-11-11 11:19 ` Andrew Burgess (Code Review)
2019-11-14  9:55 ` Eli Zaretskii [this message]
2019-11-22 23:53 ` Tom Tromey (Code Review)
2019-11-22 23:54 ` [review v2] " Tom Tromey (Code Review)
2019-11-23  7:21   ` Eli Zaretskii
2019-11-28 10:12 ` Andrew Burgess (Code Review)
2019-12-01 19:04 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-01 19:04 ` Sourceware to Gerrit sync (Code Review)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83pnhu7peu.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).