From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23207 invoked by alias); 17 Jan 2018 15:33:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23184 invoked by uid 89); 17 Jan 2018 15:33:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Jan 2018 15:33:03 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebphx-00049t-DW for gdb-patches@sourceware.org; Wed, 17 Jan 2018 10:33:00 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36096) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebphx-00049j-Ap; Wed, 17 Jan 2018 10:32:57 -0500 Received: from [176.228.60.248] (port=2395 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ebphw-0003cC-PJ; Wed, 17 Jan 2018 10:32:57 -0500 Date: Wed, 17 Jan 2018 15:33:00 -0000 Message-Id: <83po68wlel.fsf@gnu.org> From: Eli Zaretskii To: Sergio Durigan Junior CC: gdb-patches@sourceware.org In-reply-to: <20180116194641.22361-1-sergiodj@redhat.com> (message from Sergio Durigan Junior on Tue, 16 Jan 2018 14:46:41 -0500) Subject: Re: [PATCH] Fix warning on gdb/compile/compile.c (C++-ify "triplet_rx") Reply-to: Eli Zaretskii References: <87po69zkxe.fsf@redhat.com> <20180116194641.22361-1-sergiodj@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00340.txt.bz2 > From: Sergio Durigan Junior > Cc: Eli Zaretskii , Sergio Durigan Junior > Date: Tue, 16 Jan 2018 14:46:41 -0500 > > This fixes a GCC warning that happens when compiling > gdb/compile/compile.c on some GCC versions (e.g., "gcc (GCC) 7.2.1 > 20180104 (Red Hat 7.2.1-6)"). > > It's a simple patch that converts "triplet_rx" from "char *" to > "std::string", thus guaranteeing that it will be always initialized. > > I've regtested this patch and did not find any regressions. OK to > apply on both master and 8.1 (after creating a bug for it)? > > gdb/ChangeLog: > 2018-01-16 Sergio Durigan Junior > > * compile/compile.c (compile_to_object): Convert "triplet_rx" > to "std::string". Thanks, this fixes the warning for me.