From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14701 invoked by alias); 15 Jan 2015 18:11:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14667 invoked by uid 89); 15 Jan 2015 18:11:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mtaout28.012.net.il Received: from mtaout28.012.net.il (HELO mtaout28.012.net.il) (80.179.55.184) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Jan 2015 18:11:04 +0000 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NI800B00CNT3Y00@mtaout28.012.net.il>; Thu, 15 Jan 2015 20:09:00 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NI8004FVD303L90@mtaout28.012.net.il>; Thu, 15 Jan 2015 20:09:00 +0200 (IST) Date: Thu, 15 Jan 2015 18:11:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] Add support for embedding scripts in .debug_gdb_scripts. In-reply-to: To: Doug Evans Cc: binutils@sourceware.org, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83ppaf3oe6.fsf@gnu.org> References: X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00432.txt.bz2 > From: Doug Evans > Date: Thu, 15 Jan 2015 09:31:48 -0800 > > +* Python/Guile scripting > + > +** GDB now supports auto-loading of Python/Guile scripts contained in the > + special section named `.debug_gdb_scripts'. I think we should tell here on what systems/targets this is supported. Otherwise, the NEWS entry is OK. > For systems using file formats like ELF and COFF, > when @value{GDBN} loads a new object file > it will look for a special section named @code{.debug_gdb_scripts}. Is this really supported with non-ELF targets? E.g., does pe-coff (Windows) support such sections? > +If this section exists, its contents is a list of NUL-terminated entries > +specifying scripts to load. Each entry begins with a non-NULL prefix byte that Let's be consistent here" "null", lower-case and with 2 'l'. This is just a plain English word, not an acronym or a C symbol. > +Supported values for the prefix byte are define in the ^^^^^^ "defined" > +@file{include/gdb/section-scripts.h} file in the @value{GDBN} source tree. Is this really helpful? If that file is installed, let's mention where to find it in the installed tree; if it is not installed, we ought to list the values here, since the reader might not have access to the source tree, let alone the one from which the binary was produced. > +The following entries are supported: > + > +@table @code > +@item SECTION_SCRIPT_ID_PYTHON_FILE = 1 > +@item SECTION_SCRIPT_ID_SCHEME_FILE = 3 > +@item SECTION_SCRIPT_ID_PYTHON_TEXT = 4 > +@item SECTION_SCRIPT_ID_SCHEME_TEXT = 6 > +@end table Are these the values of the prefix byte? If so, we should simply skip the pointer to the source tree. > +@subsubsection Script Text Entries > + > +In script text entries the script to execute is contained in the entry > +instead of being loaded from a file. Suggest to reword this sentence: Script text entries allow to put the executable script in the entry itself instead of loading it from a file. > +The rest of the entry, up to the trailing NUL byte, ^^^ "null" > is the script to > +execute in the specified language. Specified how and by what means? > +Loading of inlined scripts require a properly configured ^^^^^^^ "requires" Thanks.