From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76207-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23174 invoked by alias); 26 Oct 2010 17:41:53 -0000
Received: (qmail 23111 invoked by uid 22791); 26 Oct 2010 17:41:52 -0000
X-SWARE-Spam-Status: No, hits=-0.7 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 26 Oct 2010 17:41:44 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LAW00000RPUC100@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Tue, 26 Oct 2010 19:41:26 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.127.168.113]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LAW00NQ1RT03I30@a-mtaout22.012.net.il>; Tue, 26 Oct 2010 19:41:26 +0200 (IST)
Date: Tue, 26 Oct 2010 17:41:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch] Fix avoiding of unnecessary psymtabs in dwarf_decode_lines
In-reply-to: <20101026133928.GB2847@adacore.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: dje@google.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83pquw7sxl.fsf@gnu.org>
References: <20100825000001.9D9A484B8E@ruffy.mtv.corp.google.com> <20101026133928.GB2847@adacore.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-10/txt/msg00372.txt.bz2

> Date: Tue, 26 Oct 2010 09:39:28 -0400
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
> 
> [I am soooo far behind on gdb patches :-(]
> 
> > +  file_is_pst = strcmp (include_name_to_compare, pst_filename) == 0;
> 
> I know that the original code was already using strcmp to do the
> comparison, but shouldn't we be using FILENAME_CMP instead.  That should
> take care of platforms where the filesystem is case insensitive...

Yes, definitely.  Thanks for catching this.