From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 0B73B3858CDA for ; Thu, 30 Mar 2023 14:13:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0B73B3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pht2G-00018F-8X; Thu, 30 Mar 2023 10:13:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=m/9c8c79eqG8WwDApHRqE2uDEBe9LiaAoAfsyyFJpnI=; b=NyuuFfHNhGa0 bZc7OrYJ9R2nSKgkJx7yHrxDCldZ4ohi/a8wthG36srD5hYodO3btNgP3ghevQtAjbqJFI6S1ZjpV EroNmgBMHNRFPAYqCEehXNLCTXZAi/15z6C7+7rvn487mNmjRj8tLvcSNuqUMsf5rBJd0hjTkvGXo 8YIDe56AA4YznoZIuq8IxPr71KhN55mTcvCn5vGMO0dU9od5tAj/wFz0WXOJ8tiJYVVHP1WeJNsuq qf6W6gVqcjaSM15WsFV1zgyRl3B1rtSoPuqAi2F1YL1YHNgzvUsj44NYhai7s+AqYLaYFp2FaoEpN I4TV99A1BT+Ont1T4pi7LA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pht2E-0005JQ-Ds; Thu, 30 Mar 2023 10:13:51 -0400 Date: Thu, 30 Mar 2023 17:13:52 +0300 Message-Id: <83r0t6499b.fsf@gnu.org> From: Eli Zaretskii To: Andrew Burgess Cc: gdb-patches@sourceware.org In-Reply-To: <2b2fd6d7cda91c3bd4f8ea3241041fe6ae44f584.1680177890.git.aburgess@redhat.com> (message from Andrew Burgess via Gdb-patches on Thu, 30 Mar 2023 13:10:21 +0100) Subject: Re: [PATCH 2/4] gdb/python: have PendingFrame methods accept keyword arguments References: <2b2fd6d7cda91c3bd4f8ea3241041fe6ae44f584.1680177890.git.aburgess@redhat.com> X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: Andrew Burgess > Date: Thu, 30 Mar 2023 13:10:21 +0100 > From: Andrew Burgess via Gdb-patches > > diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi > index ef50e6dbe7b..4f62ca7d95e 100644 > --- a/gdb/doc/python.texi > +++ b/gdb/doc/python.texi > @@ -2756,11 +2756,11 @@ > An object passed to an unwinder (a @code{gdb.PendingFrame} instance) > provides a method to read frame's registers: > > -@defun PendingFrame.read_register (reg) > -This method returns the contents of the register @var{reg} in the > +@defun PendingFrame.read_register (@var{register}) Same issue with @var here. > +This method returns the contents of the register @var{register} in the It is usually much better to say "...contents of @var{register}". It avoids unnecessary tautology. Thanks. Reviewed-By: Eli Zaretskii