From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id C48163858D1E for ; Fri, 10 Mar 2023 12:06:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C48163858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pabWB-0002Hs-Ak; Fri, 10 Mar 2023 07:06:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fWn0stPiMt5jxFlB9XzxrkAeg9Xq7/Ls8EdxuVEZ3Jg=; b=j2Tp7PBFUksS UHjl3QQx0pNzbQb8jisHN8yNSHKLQqtCNrKylsPeGWExBI+LSSRHYhrzqoH5VMly4vrT7yQ3J4xwa 7QeZKBmdshK53SI0/WQLcSSOweGSK8QJQgA8yT8rHqGc76isxP1EVgP+0S55xASZQDtZqxu6ZeJDT iFcNyhhVwU0o0pdE3h3QZyJ898Ou3gpNQqe98E65sR9k0zeF7YDShJoWiRxUk0nP/Cp73VOrbrKAl hHhjfGK2LYAYXeMSrVoYG9EA4BIt62sQEr2tQfrvsxwUPnPp8fGq1ZHVwTtJsvqYupwdK+4qb5RNG cmk2Qj45iQ+n4UAXcsHCTw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pabVl-0007u6-0X; Fri, 10 Mar 2023 07:06:19 -0500 Date: Fri, 10 Mar 2023 14:05:56 +0200 Message-Id: <83r0twzu8r.fsf@gnu.org> From: Eli Zaretskii To: Gareth Rees Cc: aburgess@redhat.com, gdb-patches@sourceware.org In-Reply-To: (message from Gareth Rees on Fri, 10 Mar 2023 11:04:42 +0000) Subject: Re: [PATCH v5] [PR mi/29554] New PRINT-VALUES option '--scalar-values'. References: <87fsftateu.fsf@redhat.com> <20221020174702.514681-1-grees@undo.io> <87bkl3h153.fsf@redhat.com> X-Spam-Status: No, score=1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Gareth Rees > Date: Fri, 10 Mar 2023 11:04:42 +0000 > Cc: gdb-patches@sourceware.org > > This also makes sense to me, but this is not a decision that I am in a > position to make! The experienced GDB developers -- in particular, you > and Eli -- need to come to an agreement about which approach is best > in this case: do you prefer to take the risk of a backward- > incompatible change (GDB/MI clients can no longer get the values for > references to compound types in C++ programs using --simple-values) or > do you prefer to accept the cost of leaving (what looks like) a > mistake to stand forever? I can implement whichever you think is best. > > For the moment I will prepare a revised patch implementing solution #1 > and addressing your other review comments. If Eli can also follow up > and help us reach a conclusion on the best design, that would be > great. The reason why I preferred #2 is simple: it avoids incompatible changes in the behavior of existing options. Since it was not really clear-cut that the previous behavior was a bug, the backward incompatibility could cause trouble to some application or use case which didn't consider it was a bug and relied on that behavior. Introducing a new option is free from this problem.