From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 2A6D9385842B for ; Thu, 8 Sep 2022 14:08:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2A6D9385842B Received: from fencepost.gnu.org ([2001:470:142:3::e]:35892) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWICO-0001xa-GG; Thu, 08 Sep 2022 10:08:08 -0400 Received: from [87.69.77.57] (port=1865 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWICN-0007MS-Em; Thu, 08 Sep 2022 10:08:08 -0400 Date: Thu, 08 Sep 2022 17:07:54 +0300 Message-Id: <83r10mdkn9.fsf@gnu.org> From: Eli Zaretskii To: Gareth Rees Cc: gdb-patches@sourceware.org In-Reply-To: (message from Gareth Rees on Thu, 8 Sep 2022 14:58:22 +0100) Subject: Re: [PATCH v2] [gdb/mi] Don't treat references to compound values as "simple". References: <877d2ema8q.fsf@redhat.com> <20220908110248.1084-1-grees@undo.io> <834jxif0yp.fsf@gnu.org> X-Spam-Status: No, score=1.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2022 14:08:10 -0000 > From: Gareth Rees > Date: Thu, 8 Sep 2022 14:58:22 +0100 > Cc: gdb-patches@sourceware.org > > > Isn't it easier to say "only if the value is a scalar"? > > I deliberately echoed the wording used in the documentation for > '-stack-list-arguments' and similar commands, which uses the formula > "if it is 2 or --simple-values, print the name, type and value for > simple data types, and the name and type for arrays, structures and > unions." > > But you are right that this concept corresponds to the 'scalars' > arguments to 'set print frame-arguments'. But then should I update the > documentation for '-stack-list-arguments' to match? It would be nice, yes. But you don't have to, it could be left for a separate changeset.