From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 6DBEA3858D33
 for <gdb-patches@sourceware.org>; Tue, 31 May 2022 11:55:38 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6DBEA3858D33
Received: from fencepost.gnu.org ([2001:470:142:3::e]:34988)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nw0TI-0000Ag-4c; Tue, 31 May 2022 07:55:36 -0400
Received: from [87.69.77.57] (port=3745 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nw0TH-0004sO-KX; Tue, 31 May 2022 07:55:35 -0400
Date: Tue, 31 May 2022 14:55:41 +0300
Message-Id: <83r149j4qq.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
In-Reply-To: <aa030bd8-374c-67ae-923f-144b2e6b278f@palves.net> (message from
 Pedro Alves on Tue, 31 May 2022 12:31:40 +0100)
Subject: Re: [PATCH] Improve break-range's documentation
References: <20220526194250.2310460-1-pedro@palves.net>
 <838rqmm7gb.fsf@gnu.org> <6914f754-4e33-5aa1-4ea6-dca9504e8bfe@palves.net>
 <837d63j8tx.fsf@gnu.org> <aa030bd8-374c-67ae-923f-144b2e6b278f@palves.net>
X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 31 May 2022 11:55:39 -0000

> Date: Tue, 31 May 2022 12:31:40 +0100
> Cc: gdb-patches@sourceware.org
> From: Pedro Alves <pedro@palves.net>
> 
>  Set a breakpoint for an address range given by @var{start-locspec} and
>  @var{end-locspec}, which are location specs.  @xref{Location
>  Specifications}, for a list of all the possible forms of location
> -specs.  If either @var{start-locspec} or @var{end-locspec} resolve to
> -multiple addresses in the program, then the command aborts with an
> -error without creating a breakpoint.  The breakpoint will stop
> -execution of the inferior whenever it executes an instruction at any
> -address within the specified range, including @var{start-locspec} and
> -@var{end-locspec}.
> +specs.  @value{GDBN} resolves both @var{start-locspec} and
> +@var{end-locspec}, and uses the addresses of the resolved code
> +locations as start and end addresses of the range to break at.  If
> +either @var{start-locspec} or @var{end-locspec} resolve to multiple
> +code locations in the program, then the command aborts with an error
> +without creating a breakpoint.  The breakpoint will stop execution of
> +the inferior whenever it executes an instruction at any address
> +between the start and end addresses, inclusive.

This is fine, but please swap the last sentence with the one before
it, since, as written, the penultimate sentence breaks the logic of
the description of what the command does by describing an exceptional
situation too early.

Thanks.