public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add gdb.current_language function
Date: Fri, 27 May 2022 20:48:51 +0300	[thread overview]
Message-ID: <83r14en9x8.fsf@gnu.org> (raw)
In-Reply-To: <20220527173642.1180218-1-tromey@adacore.com> (message from Tom Tromey via Gdb-patches on Fri, 27 May 2022 11:36:42 -0600)

> Date: Fri, 27 May 2022 11:36:42 -0600
> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Tom Tromey <tromey@adacore.com>
> 
> This adds the gdb.current_language function, which can be used to find
> the current language without (1) ever having the value "auto" or (2)
> having to parse the output of "show language".
> ---
>  gdb/NEWS                                  |  4 ++++
>  gdb/doc/python.texi                       |  6 ++++++
>  gdb/python/python.c                       | 12 ++++++++++++
>  gdb/testsuite/gdb.python/py-parameter.exp | 13 +++++++++++++
>  4 files changed, 35 insertions(+)

Thanks.

> +  ** New function gdb.current_language() that returns the name of the

Please remove the "()" part, it is not needed there, and can be
misinterpreted.

> +@defun gdb.current_language ()
> +Return the name of the current language as a string.  Note that,
> +unlike @code{gdb.parameter(language')}, this function will never
                             ^^
A quote missing there.

The documentation parts are okay with these nits fixed.

  reply	other threads:[~2022-05-27 17:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-27 17:36 Tom Tromey
2022-05-27 17:48 ` Eli Zaretskii [this message]
2022-05-28 15:09 ` Enze Li
2022-05-31 13:53   ` Tom Tromey
2022-05-30  9:29 ` Andrew Burgess
2022-05-31 14:01   ` Tom Tromey
2022-05-31 15:50     ` Eli Zaretskii
2022-05-31 16:25     ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r14en9x8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).