From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id E669D3857807 for ; Tue, 25 Aug 2020 16:00:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E669D3857807 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eliz@gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]:40931) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAbNO-000430-09; Tue, 25 Aug 2020 12:00:46 -0400 Received: from [176.228.60.248] (port=3662 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kAbNN-0000i5-1S; Tue, 25 Aug 2020 12:00:45 -0400 Date: Tue, 25 Aug 2020 19:00:29 +0300 Message-Id: <83r1ru4swy.fsf@gnu.org> From: Eli Zaretskii To: Shahab Vahedi Cc: gdb-patches@sourceware.org, shahab@synopsys.com, simark@simark.ca, tom@tromey.com, anton.kolesov@synopsys.com, fbedard@synopsys.com In-Reply-To: <20200825154704.29312-2-shahab.vahedi@gmail.com> (message from Shahab Vahedi on Tue, 25 Aug 2020 17:47:01 +0200) Subject: Re: [PUSHED 1/4] arc: Add ARCv2 XML target along with refactoring References: <20200326125206.13120-1-shahab.vahedi@gmail.com> <20200825154704.29312-1-shahab.vahedi@gmail.com> <20200825154704.29312-2-shahab.vahedi@gmail.com> X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Aug 2020 16:00:49 -0000 > From: Shahab Vahedi > Cc: Shahab Vahedi , > Shahab Vahedi , > Simon Marchi , > Tom Tromey , > Eli Zaretskii , > Anton Kolesov , > Francois Bedard > Date: Tue, 25 Aug 2020 17:47:01 +0200 > > gdb/ChangeLog: > > * arch/arc.h > (arc_gdbarch_features): New class to stir the selection of target XML. > (arc_create_target_description): Use FEATURES to choose XML target. > (arc_lookup_target_description): Use arc_create_target_description > to create _new_ target descriptions or return the already created > ones if the FEATURES is the same. > * arch/arc.c: Implementation of prototypes described above. > * gdb/arc-tdep.h (arc_regnum enum): Add more registers. > (arc_gdbarch_features_init): Initialize the FEATURES struct. > * arc-tdep.c (*_feature_name): Make feature names consistent. > (arc_register_feature): A new struct to hold information about > registers of a particular target/feature. > (arc_check_tdesc_feature): Check if XML provides registers in > compliance with ARC_REGISTER_FEATURE structs. > (arc_update_acc_reg_names): Add aliases for r58 and r59. > (determine_*_reg_feature_set): Which feature name to look for. > (arc_gdbarch_features_init): Given MACH and ABFD, initialize FEATURES. > (mach_type_to_arc_isa): Convert from a set of binutils machine types > to expected ISA enums to be used in arc_gdbarch_features structs. > * features/Makefile (FEATURE_XMLFILES): Add new files. > * gdb/features/arc/v1-aux.c: New file. > * gdb/features/arc/v1-aux.xml: Likewise. > * gdb/features/arc/v1-core.c: Likewise. > * gdb/features/arc/v1-core.xml: Likewise. > * gdb/features/arc/v2-aux.c: Likewise. > * gdb/features/arc/v2-aux.xml: Likewise. > * gdb/features/arc/v2-core.c: Likewise. > * gdb/features/arc/v2-core.xml: Likewise. > * NEWS (Changes since GDB 9): Announce obsolence of old feature names. > > gdb/doc/ChangeLog: > > * gdb.texinfo (Synopsys ARC): Update the documentation for ARC > Features. > > gdb/testsuite/ChangeLog: > > * gdb.arch/arc-tdesc-cpu.xml: Use new feature names. Thanks, the documentation parts are OK.