public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Fix link order on Windows
@ 2019-06-02  9:14 orgads
  2019-06-03 15:11 ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: orgads @ 2019-06-02  9:14 UTC (permalink / raw)
  To: gdb-patches; +Cc: Orgad Shaneh

From: Orgad Shaneh <orgads@gmail.com>

libgnu uses ntop, which comes from ws2_32 library, so ws2_32 needs
to be linked after libgnu.
---
 gdb/Makefile.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 5614cc3386..037f9ae356 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -595,8 +595,8 @@ CLIBS = $(SIM) $(READLINE) $(OPCODES) $(BFD) $(ZLIB) $(INTL) $(LIBIBERTY) $(LIBD
        $(XM_CLIBS) $(GDBTKLIBS) \
        @LIBS@ @GUILE_LIBS@ @PYTHON_LIBS@ \
        $(LIBEXPAT) $(LIBLZMA) $(LIBBABELTRACE) $(LIBIPT) \
-       $(LIBIBERTY) $(WIN32LIBS) $(LIBGNU) $(LIBICONV) $(LIBMPFR) \
-       $(SRCHIGH_LIBS)
+       $(LIBIBERTY) $(LIBGNU) $(LIBICONV) $(LIBMPFR) \
+       $(SRCHIGH_LIBS) $(WIN32LIBS)
 CDEPS = $(NAT_CDEPS) $(SIM) $(BFD) $(READLINE_DEPS) \
        $(OPCODES) $(INTL_DEPS) $(LIBIBERTY) $(CONFIG_DEPS) $(LIBGNU)

--
2.22.0.rc0.windows.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix link order on Windows
  2019-06-02  9:14 [PATCH] Fix link order on Windows orgads
@ 2019-06-03 15:11 ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2019-06-03 15:11 UTC (permalink / raw)
  To: orgads; +Cc: gdb-patches

> From: orgads@gmail.com
> Cc: Orgad Shaneh <orgads@gmail.com>
> Date: Sun,  2 Jun 2019 09:13:52 +0000
> 
> From: Orgad Shaneh <orgads@gmail.com>
> 
> libgnu uses ntop, which comes from ws2_32 library, so ws2_32 needs
> to be linked after libgnu.
> ---
>  gdb/Makefile.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index 5614cc3386..037f9ae356 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -595,8 +595,8 @@ CLIBS = $(SIM) $(READLINE) $(OPCODES) $(BFD) $(ZLIB) $(INTL) $(LIBIBERTY) $(LIBD
>         $(XM_CLIBS) $(GDBTKLIBS) \
>         @LIBS@ @GUILE_LIBS@ @PYTHON_LIBS@ \
>         $(LIBEXPAT) $(LIBLZMA) $(LIBBABELTRACE) $(LIBIPT) \
> -       $(LIBIBERTY) $(WIN32LIBS) $(LIBGNU) $(LIBICONV) $(LIBMPFR) \
> -       $(SRCHIGH_LIBS)
> +       $(LIBIBERTY) $(LIBGNU) $(LIBICONV) $(LIBMPFR) \
> +       $(SRCHIGH_LIBS) $(WIN32LIBS)
>  CDEPS = $(NAT_CDEPS) $(SIM) $(BFD) $(READLINE_DEPS) \
>         $(OPCODES) $(INTL_DEPS) $(LIBIBERTY) $(CONFIG_DEPS) $(LIBGNU)
> 

LGTM, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-03 15:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-02  9:14 [PATCH] Fix link order on Windows orgads
2019-06-03 15:11 ` Eli Zaretskii

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).