From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63008 invoked by alias); 1 Mar 2019 07:47:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62424 invoked by uid 89); 1 Mar 2019 07:47:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=filtering, utils.c, UD:utils.c, utilsc X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Mar 2019 07:47:41 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59356) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzctO-0002AV-5E; Fri, 01 Mar 2019 02:47:39 -0500 Received: from [176.228.60.248] (port=4242 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gzctN-0004TF-GW; Fri, 01 Mar 2019 02:47:38 -0500 Date: Fri, 01 Mar 2019 07:47:00 -0000 Message-Id: <83r2brhw8k.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: gdb-patches@sourceware.org In-reply-to: <8736rja4i8.fsf@tromey.com> (message from Tom Tromey on Thu, 29 Nov 2018 15:43:59 -0700) Subject: Re: [PATCH 00/16] Add styling to the gdb CLI and TUI References: <20181128001435.12703-1-tom@tromey.com> <83k1kxfzwo.fsf@gnu.org> <8736rja4i8.fsf@tromey.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00000.txt.bz2 > From: Tom Tromey > Cc: Tom Tromey , gdb-patches@sourceware.org > Date: Thu, 29 Nov 2018 15:43:59 -0700 > > >>>>> "Eli" == Eli Zaretskii writes: > > Eli> Will the Windows TUI build support styling out of the box? It uses > Eli> ncurses. > > I think it should work, but you'd have to "set style enabled on" first. For the record, it doesn't work in GDB 8.2.90, even after I disabled the test for $TERM being defined in the environment. I will try to find out why at some point. > I think either utils.c would have to be modified to change where it > sends output, or stdio_file::puts would have to be modified. The idea > there would be to call a host-specific function; and then on Windows do > the filtering+styling if the output is going to the terminal. I'm looking into this now. The simplest change would be to modify stdio_file::puts that performs the filtering only on Windows, but the fact that you mentioned calling a host-specific function confuses me a little. Can you elaborate on what you had in mind, and specifically what kind of a host-specific function should be involved here, and how? Thanks.