From: Eli Zaretskii <eliz@gnu.org>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: palves@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 13/13] [wip] btrace: support Intel(R) Processor Trace
Date: Thu, 20 Nov 2014 16:32:00 -0000 [thread overview]
Message-ID: <83r3wx6dfg.fsf@gnu.org> (raw)
In-Reply-To: <1416480444-9943-14-git-send-email-markus.t.metzger@intel.com>
> From: Markus Metzger <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org
> Date: Thu, 20 Nov 2014 11:47:24 +0100
>
> Adds a new command "record btrace pt" to configure the kernel to use
> Intel Processor Trace instead of Intel Branch Trace Strore.
Thanks.
> + warning (_("decode error near offset 0x%" PRIx64
Warning messages like this are sub-optimal, because they don't give
enough context to understand what happens. The user will likely
wonder what was GDB decoding when it hit that error.
> + error (_("Failed to configure trace decoder: %s."),
> + pt_errstr (pt_errcode (errcode)));
Likewise here: what "trace decoder" is being referred to?
I suggest to add text that provides the missing context, like "Failed
to configure trace decoder for Intel Process Trace."
> +If @var{size} is a positive number, then @value{GDBN} will try to
> +allocate a buffer of at least @var{size} bytes for each new thread
> +that uses the btrace recording method and the Intel Processor Trace
> +format. The actually obtained buffer size may differ from the
> +requested @var{size}. Use the @code{info record} command to see the
^^
Two spaces here.
The documentation parts are OK with that fixed.
prev parent reply other threads:[~2014-11-20 16:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 10:47 [PATCH v2 00/13] record btrace: prepare for a new trace format Markus Metzger
2014-11-20 10:47 ` [PATCH v2 07/13] btrace: extend struct btrace_insn Markus Metzger
2014-11-20 10:47 ` [PATCH v2 02/13] btrace: add format argument to supports_btrace Markus Metzger
2014-11-20 10:47 ` [PATCH v2 09/13] btrace: identify cpu Markus Metzger
2014-11-20 10:47 ` [PATCH v2 10/13] btrace: use the new cpu identifier Markus Metzger
2014-11-20 10:47 ` [PATCH v2 04/13] record btrace: add configuration struct Markus Metzger
2014-11-20 10:47 ` [PATCH v2 08/13] btrace: move and rename btrace-common Markus Metzger
2015-01-27 11:25 ` Pedro Alves
2015-01-28 17:58 ` Metzger, Markus T
2014-11-20 10:47 ` [PATCH v2 03/13] btrace, linux: add perf event buffer abstraction Markus Metzger
2015-01-27 15:31 ` Pedro Alves
2015-01-27 18:14 ` Metzger, Markus T
2015-01-27 18:15 ` Pedro Alves
2015-01-28 16:50 ` Metzger, Markus T
2014-11-20 10:47 ` [PATCH v2 12/13] configure: check for libipt Markus Metzger
2014-11-20 10:47 ` [PATCH v2 11/13] record-btrace: indicate gaps Markus Metzger
2014-11-20 17:32 ` Metzger, Markus T
2014-11-20 17:36 ` Eli Zaretskii
2014-11-20 10:47 ` [PATCH v2 05/13] record-btrace: add bts buffer size configuration option Markus Metzger
2014-11-20 16:25 ` Eli Zaretskii
2014-11-20 10:47 ` [PATCH v2 01/13] btrace: add struct btrace_data Markus Metzger
2015-01-27 11:29 ` Pedro Alves
2014-11-20 10:47 ` [PATCH v2 06/13] btrace: update btrace_compute_ftrace parameters Markus Metzger
2014-11-20 10:47 ` [PATCH v2 13/13] [wip] btrace: support Intel(R) Processor Trace Markus Metzger
2014-11-20 16:32 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r3wx6dfg.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).