From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-117685-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24926 invoked by alias); 20 Nov 2014 16:32:09 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 24917 invoked by uid 89); 20 Nov 2014 16:32:08 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout23.012.net.il
Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Nov 2014 16:32:07 +0000
Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NFC00E00J4RO800@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Thu, 20 Nov 2014 18:32:04 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NFC00EMXJ9GJZ80@a-mtaout23.012.net.il>; Thu, 20 Nov 2014 18:32:04 +0200 (IST)
Date: Thu, 20 Nov 2014 16:32:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v2 13/13] [wip] btrace: support Intel(R) Processor Trace
In-reply-to: <1416480444-9943-14-git-send-email-markus.t.metzger@intel.com>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: palves@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83r3wx6dfg.fsf@gnu.org>
References: <1416480444-9943-1-git-send-email-markus.t.metzger@intel.com> <1416480444-9943-14-git-send-email-markus.t.metzger@intel.com>
X-IsSubscribed: yes
X-SW-Source: 2014-11/txt/msg00477.txt.bz2

> From: Markus Metzger <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org
> Date: Thu, 20 Nov 2014 11:47:24 +0100
> 
> Adds a new command "record btrace pt" to configure the kernel to use
> Intel Processor Trace instead of Intel Branch Trace Strore.

Thanks.

> +      warning (_("decode error near offset 0x%" PRIx64

Warning messages like this are sub-optimal, because they don't give
enough context to understand what happens.  The user will likely
wonder what was GDB decoding when it hit that error.

> +    error (_("Failed to configure trace decoder: %s."),
> +	   pt_errstr (pt_errcode (errcode)));

Likewise here: what "trace decoder" is being referred to?

I suggest to add text that provides the missing context, like "Failed
to configure trace decoder for Intel Process Trace."

> +If @var{size} is a positive number, then @value{GDBN} will try to
> +allocate a buffer of at least @var{size} bytes for each new thread
> +that uses the btrace recording method and the Intel Processor Trace
> +format.  The actually obtained buffer size may differ from the
> +requested @var{size}. Use the @code{info record} command to see the
                       ^^
Two spaces here.

The documentation parts are OK with that fixed.