From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 54D913858D35 for ; Mon, 22 May 2023 13:47:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 54D913858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q15sp-0005W3-Lx; Mon, 22 May 2023 09:47:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=IhGfRWrJl7t8X/C5XGdObxvr60fygnFfeTvI7R8tK00=; b=T+B2HKjNKwBt BzR5AkmhYbzmdLowxftc7Sa/hNZCiCSdyHt+ESJp/LldGXxeeltmqYlqUFybYUoyKqfnD8KtAys8Y 5C7uCXpgMydvgA+Niq3B3w27icIKE7hGqi+s25rnyNP/tGOivWBAqyTXThfAz/dca6NdOKkV7tNW4 4eXkxgFiyC/6NXOShFlBIIJX3FZ+PR9nSLisMlxvZd0yeQN/WzKaGKe5xz5FAPEJ9hlGDxeXK4cey 334C8CppnJQM1oQNFd/8D3FbJc9LufVyw4Fooz85WDNj2ba9sVNra0XQ2+5vzcJuJ5hNQC7ExJGQF 8ijfPDCxr6b1xvwnYUEiHw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q15ry-0007jB-PK; Mon, 22 May 2023 09:46:54 -0400 Date: Mon, 22 May 2023 16:47:01 +0300 Message-Id: <83sfbopjfu.fsf@gnu.org> From: Eli Zaretskii To: Tom de Vries Cc: gdb-patches@sourceware.org In-Reply-To: <20230522131545.12291-3-tdevries@suse.de> (message from Tom de Vries via Gdb-patches on Mon, 22 May 2023 15:15:40 +0200) Subject: Re: [PATCH] [gdb/tui] Add set style tui-status-window References: <20230522131545.12291-1-tdevries@suse.de> <20230522131545.12291-3-tdevries@suse.de> X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: Tom Tromey > Date: Mon, 22 May 2023 15:15:40 +0200 > From: Tom de Vries via Gdb-patches > > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -27300,6 +27300,13 @@ general styling to @value{GDBN}. @xref{TUI Configuration}. > Control the styling of the active TUI border; that is, the TUI window > that has the focus. > > +@item tui-status-window > +Control the styling of the TUI status window. Note that, unlike other > +styling options, the tui-border has a mode rather than an intensity. > +The values for mode are the same as for @ref{set tui border-mode} and > +@ref{set tui active-border-mode}. By default, this style's mode is This use of @ref is not recommended. It looks better in the HTML version of the manual, but in Info and in PDF it looks like a typo or editing error. I suggest to use @pxref instead, like this: The values for mode are the same as for tui border-mode (@pxref{set tui border-mode}) and tui active-border-mode. It might look less elegant in HTML, but much better in other formats. > +standout, and the foreground and background colors are none. ^^^^ "@code{none}", perhaps? > +@anchor{set tui border-mode} > @item set tui border-mode @var{mode} > @kindex set tui border-mode > +@anchor{set tui active-border-mode} > @itemx set tui active-border-mode @var{mode} > @kindex set tui active-border-mode If you go with my suggestion above about @pxref, you don't need the second one of these @anchor's. Thanks. Reviewed-By: Eli Zaretskii