From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id B6471382EA13
 for <gdb-patches@sourceware.org>; Fri, 16 Sep 2022 14:21:26 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B6471382EA13
Received: from fencepost.gnu.org ([2001:470:142:3::e]:46740)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1oZCDS-0004mc-Ce; Fri, 16 Sep 2022 10:21:25 -0400
Received: from [87.69.77.57] (port=1688 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1oZCDK-0008VT-P9; Fri, 16 Sep 2022 10:21:13 -0400
Date: Fri, 16 Sep 2022 17:21:04 +0300
Message-Id: <83sfkr2yen.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: "Willgerodt, Felix" <felix.willgerodt@intel.com>
Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com
In-Reply-To: <MN2PR11MB456678E2951D7451DEEEFBD08E489@MN2PR11MB4566.namprd11.prod.outlook.com>
 (felix.willgerodt@intel.com)
Subject: Re: [PATCH v6 10/10] btrace: Extend ptwrite event decoding.
References: <20220916113646.49749-1-felix.willgerodt@intel.com>
 <20220916113646.49749-11-felix.willgerodt@intel.com> <831qsb4jfj.fsf@gnu.org>
 <MN2PR11MB456678E2951D7451DEEEFBD08E489@MN2PR11MB4566.namprd11.prod.outlook.com>
X-Spam-Status: No, score=1.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Sep 2022 14:21:27 -0000

> From: "Willgerodt, Felix" <felix.willgerodt@intel.com>
> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, "Metzger,
>  Markus T" <markus.t.metzger@intel.com>
> Date: Fri, 16 Sep 2022 14:02:07 +0000
> 
> > >  *** Changes since GDB 12
> > >
> > > +* GDB now supports printing of ptwrite payloads from the Intel Processor
> > > +  Trace during 'record instruction-history', 'record function-call-history',
> > > +  all stepping commands and in  Python.  Printing is customizable via a
> > 
> > Can we rephrase the "and in Python" part to be less confusing and
> > ambiguous?  (Also, there's an extraneous blank character there.)
> 
> The NEWS file very often says "in Python".
> But it is a fair point. How about "and in the Python API?"

I think it is better to use the same wording as you did in the manual.

> > Btw, it sounds like this functionality is only available if GDB was
> > built with Python?  If so, I think other places where you mention this
> > in the manual should indicate that the feature is only available
> > through Python.
> 
> That is true. Yet most of the documentation is in python.texi for that reason.
> Do you think that is not enough?

I was talking about stuff outside of python.texi.