From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id DD1FC3857B84 for ; Thu, 2 Jun 2022 16:09:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DD1FC3857B84 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34036) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwnO8-00021S-9f; Thu, 02 Jun 2022 12:09:32 -0400 Received: from [87.69.77.57] (port=3165 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwnO6-00008p-QS; Thu, 02 Jun 2022 12:09:31 -0400 Date: Thu, 02 Jun 2022 19:09:40 +0300 Message-Id: <83sfondp2z.fsf@gnu.org> From: Eli Zaretskii To: Markus Metzger Cc: gdb-patches@sourceware.org In-Reply-To: <20220602132514.957983-6-markus.t.metzger@intel.com> (message from Markus Metzger via Gdb-patches on Thu, 2 Jun 2022 15:25:04 +0200) Subject: Re: [PATCH v5 05/15] gdb, gdbserver: extend RSP to support namespaces References: <20220602132514.957983-1-markus.t.metzger@intel.com> <20220602132514.957983-6-markus.t.metzger@intel.com> X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jun 2022 16:09:34 -0000 > Date: Thu, 2 Jun 2022 15:25:04 +0200 > From: Markus Metzger via Gdb-patches > > Introduce a new qXfer:libraries-svr4:read annex key/value pair > > lmid= > > to be used together with start and prev to provide the namespace of start > and prev to gdbserver. > > Unknown key/value pairs are ignored by gdbserver so no new supports check > is needed. > > Introduce a new library-list-svr4 library attribute > > lmid > > to provide the namespace of a library entry to GDB. > > This implementation uses the address of a namespace's r_debug object as > namespace identifier. > > This should have incremented the minor version but since unknown XML > attributes are ignored, anyway, and since changing the version results in > a warning from GDB, the version is left at 1.0. > --- > gdb/doc/gdb.texinfo | 16 +++++++++++-- > gdb/features/library-list-svr4.dtd | 4 ++++ > gdb/solib-svr4.c | 38 +++++++++++++++++++++++++++--- > gdbserver/linux-low.cc | 26 +++++++++++++------- > 4 files changed, 70 insertions(+), 14 deletions(-) The gdb.texinfo part is OK. Thanks.