From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 311DC3858C27 for ; Thu, 7 Oct 2021 13:38:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 311DC3858C27 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37230) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYTbl-0006VG-8E; Thu, 07 Oct 2021 09:38:49 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3228 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYTbk-0007pH-Rq; Thu, 07 Oct 2021 09:38:49 -0400 Date: Thu, 07 Oct 2021 16:38:45 +0300 Message-Id: <83sfxdymxm.fsf@gnu.org> From: Eli Zaretskii To: Andrew Burgess Cc: gdb-patches@sourceware.org In-Reply-To: <20211007131451.849029-1-andrew.burgess@embecosm.com> (message from Andrew Burgess on Thu, 7 Oct 2021 14:14:51 +0100) Subject: Re: [PATCH] gdb: split array and string limiting options References: <20211007131451.849029-1-andrew.burgess@embecosm.com> X-Spam-Status: No, score=2.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Oct 2021 13:38:52 -0000 > From: Andrew Burgess > Date: Thu, 7 Oct 2021 14:14:51 +0100 > > gdb/NEWS | 18 ++++++ > gdb/ada-valprint.c | 4 +- > gdb/c-lang.c | 2 +- > gdb/c-valprint.c | 4 +- > gdb/doc/gdb.texinfo | 36 +++++++++-- > gdb/language.h | 2 +- > gdb/m2-lang.c | 2 +- > gdb/m2-valprint.c | 2 +- > gdb/p-lang.c | 2 +- > gdb/p-valprint.c | 2 +- > gdb/printcmd.c | 4 +- > gdb/python/py-value.c | 6 +- > gdb/testsuite/gdb.ada/str_chars.exp | 64 +++++++++++++++++++ > gdb/testsuite/gdb.ada/str_chars/foo.adb | 26 ++++++++ > gdb/testsuite/gdb.base/default.exp | 4 +- > gdb/testsuite/gdb.base/examine-backward.exp | 6 ++ > gdb/testsuite/gdb.base/options.exp | 1 + > gdb/testsuite/gdb.base/printcmds.exp | 28 ++++---- > gdb/testsuite/gdb.base/wchar.exp | 6 +- > gdb/testsuite/gdb.base/with.exp | 2 +- > gdb/testsuite/gdb.guile/scm-pretty-print.exp | 12 ++-- > gdb/testsuite/gdb.pascal/str-chars.exp | 48 ++++++++++++++ > gdb/testsuite/gdb.pascal/str-chars.pas | 28 ++++++++ > gdb/testsuite/gdb.python/py-format-string.exp | 13 ++-- > gdb/testsuite/gdb.python/py-prettyprint.exp | 8 ++- > gdb/testsuite/lib/gdb.exp | 2 +- > gdb/tracepoint.c | 4 +- > gdb/valprint.c | 51 +++++++++++---- > gdb/valprint.h | 3 + > 29 files changed, 321 insertions(+), 69 deletions(-) > create mode 100644 gdb/testsuite/gdb.ada/str_chars.exp > create mode 100644 gdb/testsuite/gdb.ada/str_chars/foo.adb > create mode 100644 gdb/testsuite/gdb.pascal/str-chars.exp > create mode 100644 gdb/testsuite/gdb.pascal/str-chars.pas The documentation parts are okay, with one comment: you say "characters", but the code actually limits the number of bytes, not characters, right? Thanks.