From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 7B4EC395A831 for ; Fri, 12 Jun 2020 13:50:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7B4EC395A831 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eliz@gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]:35997) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjk58-0006xx-C9; Fri, 12 Jun 2020 09:50:54 -0400 Received: from [176.228.60.248] (port=2020 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jjk57-0004p3-RC; Fri, 12 Jun 2020 09:50:54 -0400 Date: Fri, 12 Jun 2020 16:50:41 +0300 Message-Id: <83sgf04clq.fsf@gnu.org> From: Eli Zaretskii To: Ludovic =?iso-8859-1?Q?Court=E8s?= Cc: gdb-patches@sourceware.org In-Reply-To: <20200612132710.14364-2-ludo@gnu.org> (message from Ludovic =?iso-8859-1?Q?Court=E8s?= on Fri, 12 Jun 2020 15:27:09 +0200) Subject: Re: [PATCH 1/2] guile: Add support for Guile 2.2. References: <20200612132710.14364-1-ludo@gnu.org> <20200612132710.14364-2-ludo@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2020 13:50:56 -0000 > From: Ludovic Courtès > Date: Fri, 12 Jun 2020 15:27:09 +0200 > Cc: Ludovic Courtès > > This primarily updates code that uses the I/O port API of Guile. > > * doc/guile.texi (Memory Ports in Guile): Remove > documentation of 'memory-port-read-buffer-size', > 'set-memory-port-read-buffer-size!', > 'memory-port-write-buffer-size', > 'set-memory-port-read-buffer-size!', which are no longer > supported with Guile 2.2/3.0 and superseded by 'setvbuf'. > * doc/guile.texi (Guile Introduction): Clarify which Guile > versions are supported. gdb/doc/ has a separate ChangeLog file; please use that to describe changes in the manual. More importantly, I don't understand why we'd want to remove the documentation of these functions. Are we removing the functions as well (I don't think I saw the code being removed)? If we are not removing the functions, why remove their docs? You say that the corresponding Guile functionality is superseded by setvbuf, but doesn't it mean the GDB-specific capability based on that will be rewritten using the new Guile features, and we can continue supporting them? Sorry for my confusion; perhaps more detailed log messages would have prevented that. Also, does any of this need to be called out in NEWS? Thanks.