From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-121760-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8118 invoked by alias); 9 Apr 2015 16:49:24 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 8103 invoked by uid 89); 9 Apr 2015 16:49:24 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout23.012.net.il
Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Apr 2015 16:49:22 +0000
Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NMJ00F00SWDBT00@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Thu, 09 Apr 2015 19:49:20 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NMJ00F0RTE77B90@a-mtaout23.012.net.il>; Thu, 09 Apr 2015 19:49:20 +0300 (IDT)
Date: Thu, 09 Apr 2015 16:49:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v5] Add Guile frame filter interface
In-reply-to: <87pp7dferl.fsf@igalia.com>
To: Andy Wingo <wingo@igalia.com>
Cc: gdb-patches@sourceware.org, dje@google.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83sic9dz6q.fsf@gnu.org>
References: <87zj6hfg6t.fsf@igalia.com> <87pp7dferl.fsf@igalia.com>
X-IsSubscribed: yes
X-SW-Source: 2015-04/txt/msg00348.txt.bz2

> From: Andy Wingo <wingo@igalia.com>
> Cc: dje@google.com
> Date: Thu, 09 Apr 2015 18:27:42 +0200
> 
> > Changes from v4 are mostly related to feedback on the unwinder
> > interface (which is a different patch).
> >
> >   * Remove enable-frame-filter! / disable-frame-filter!, and just have
> >     set-frame-filter-enabled!, which always takes a filter object and
> >     never a string.
> >
> >   * Rename #:scope to #:locus.  Names must be unique only within a
> >     locus, not among all filters.  Add #:replace? to
> >     register-frame-filter!.
> >
> >   * Limit priorities to the signed int32 range.
> >
> >   * Rename unregister-frame-filter! to remove-frame-filter!.
> >
> >   * Update docs.
> >
> >   * Compile most .scm files with -Wunbound-variable, and not
> >     -Wunbound-toplevel.
> >
> > WDYT?
> 
> Voici le patch, mesdames et messieurs:

Thanks.

> +not.  @code{scope} is the objfile or progspace in which the filter was

This sentence will begin with a lower-case letter.  Suggest to use
"The @code{scope} field" instead.

> +An decorated frame is a Guile record type that holds information about
   ^^
"A"

> +frame @var{dec}.  Each item of the list should either be a
> +@value{GDBN} symbol (@pxref{Symbols In Guile}), a pair of a
> +@value{GDBN} symbol and a @value{GDBN} value (@pxref{Values From
> +Inferior In Guile}, or a pair of a string and a @value{GDBN} value.
> +In the first case, the value will be loaded from the frame if needed.

I'm confused: the first case is when the item is a symbol, so what
value is being alluded to here?

> +@example

Please use @smallexample everywhere.

> +                         To ensure that your Guile filters can run,
> +you might need to disable any Python frame filters loaded in your
> +session.

It would be useful here to tell how, or to add a cross-reference to a
node which holds such a description.

Thanks.