From: Eli Zaretskii <eliz@gnu.org>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: palves@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 05/13] record-btrace: add bts buffer size configuration option
Date: Thu, 20 Nov 2014 16:25:00 -0000 [thread overview]
Message-ID: <83sihd6dqm.fsf@gnu.org> (raw)
In-Reply-To: <1416480444-9943-6-git-send-email-markus.t.metzger@intel.com>
> From: Markus Metzger <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
> Date: Thu, 20 Nov 2014 11:47:16 +0100
>
> Allow the size of the branch trace ring buffer to be defined by the
> user. The specified buffer size will be used when BTS tracing is
> enabled for new threads.
>
> The obtained buffer size may differ from the requested size. The
> actual buffer size for the current thread is shown in the "info record"
> command.
>
> Bigger buffers mean longer traces, but also longer processing time.
>
> CC: Eli Zaretskii <eliz@gnu.org>
>
> 2014-11-20 Markus Metzger <markus.t.metzger@intel.com>
>
> * btrace.c (parse_xml_btrace_conf_bts): Add size.
> (btrace_conf_bts_attributes): New.
> (btrace_conf_children): Add attributes.
> * common/btrace-common.h (btrace_config_bts): New.
> (btrace_config)<bts>: New.
> (btrace_config): Update comment.
> * nat/linux-btrace.c (linux_enable_btrace): Use config.
> * features/btrace-conf.dtd: Increment version. Add size
> attribute to bts element.
> * record-btrace.c (set_record_btrace_bts_cmdlist,
> show_record_btrace_bts_cmdlist): New.
> (record_btrace_adjust_size, record_btrace_print_bts_conf,
> record_btrace_print_conf, cmd_set_record_btrace_bts,
> cmd_show_record_btrace_bts): New.
> (record_btrace_info): Call record_btrace_print_conf.
> (_initialize_record_btrace): Add commands.
> * remote.c: Add PACKET_Qbtrace_conf_bts_size enum.
> (remote_protocol_features): Add Qbtrace-conf:bts:size packet.
> (btrace_sync_conf): Synchronize bts size.
> (_initialize_remote): Add Qbtrace-conf:bts:size packet.
> * NEWS: Announce new commands and new packets.
>
> doc/
> * gdb.texinfo (Branch Trace Configuration Format): Add size.
> (Process Record and Replay): Describe new set|show commands.
> (General Query Packets): Describe Qbtrace-conf:bts:size packet.
>
> testsuite/
> * gdb.btrace/buffer-size: New.
>
> gdbserver/
> * linux-low.c (linux_low_btrace_conf): Print size.
> * server.c (handle_btrace_conf_general_set): New.
> (hanle_general_set): Call handle_btrace_conf_general_set.
> (handle_query): Report Qbtrace-conf:bts:size as supported.
OK for the documentation parts.
Thanks.
next prev parent reply other threads:[~2014-11-20 16:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 10:47 [PATCH v2 00/13] record btrace: prepare for a new trace format Markus Metzger
2014-11-20 10:47 ` [PATCH v2 04/13] record btrace: add configuration struct Markus Metzger
2014-11-20 10:47 ` [PATCH v2 10/13] btrace: use the new cpu identifier Markus Metzger
2014-11-20 10:47 ` [PATCH v2 09/13] btrace: identify cpu Markus Metzger
2014-11-20 10:47 ` [PATCH v2 02/13] btrace: add format argument to supports_btrace Markus Metzger
2014-11-20 10:47 ` [PATCH v2 07/13] btrace: extend struct btrace_insn Markus Metzger
2014-11-20 10:47 ` [PATCH v2 05/13] record-btrace: add bts buffer size configuration option Markus Metzger
2014-11-20 16:25 ` Eli Zaretskii [this message]
2014-11-20 10:47 ` [PATCH v2 12/13] configure: check for libipt Markus Metzger
2014-11-20 10:47 ` [PATCH v2 11/13] record-btrace: indicate gaps Markus Metzger
2014-11-20 17:32 ` Metzger, Markus T
2014-11-20 17:36 ` Eli Zaretskii
2014-11-20 10:47 ` [PATCH v2 08/13] btrace: move and rename btrace-common Markus Metzger
2015-01-27 11:25 ` Pedro Alves
2015-01-28 17:58 ` Metzger, Markus T
2014-11-20 10:47 ` [PATCH v2 03/13] btrace, linux: add perf event buffer abstraction Markus Metzger
2015-01-27 15:31 ` Pedro Alves
2015-01-27 18:14 ` Metzger, Markus T
2015-01-27 18:15 ` Pedro Alves
2015-01-28 16:50 ` Metzger, Markus T
2014-11-20 10:47 ` [PATCH v2 06/13] btrace: update btrace_compute_ftrace parameters Markus Metzger
2014-11-20 10:47 ` [PATCH v2 01/13] btrace: add struct btrace_data Markus Metzger
2015-01-27 11:29 ` Pedro Alves
2014-11-20 10:47 ` [PATCH v2 13/13] [wip] btrace: support Intel(R) Processor Trace Markus Metzger
2014-11-20 16:32 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sihd6dqm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).