From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12237 invoked by alias); 20 Nov 2014 16:25:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12227 invoked by uid 89); 20 Nov 2014 16:25:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout24.012.net.il Received: from mtaout24.012.net.il (HELO mtaout24.012.net.il) (80.179.55.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Nov 2014 16:25:25 +0000 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NFC00E00IKC1Z00@mtaout24.012.net.il> for gdb-patches@sourceware.org; Thu, 20 Nov 2014 18:17:44 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NFC004H2ILKD390@mtaout24.012.net.il>; Thu, 20 Nov 2014 18:17:44 +0200 (IST) Date: Thu, 20 Nov 2014 16:25:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH v2 05/13] record-btrace: add bts buffer size configuration option In-reply-to: <1416480444-9943-6-git-send-email-markus.t.metzger@intel.com> To: Markus Metzger Cc: palves@redhat.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83sihd6dqm.fsf@gnu.org> References: <1416480444-9943-1-git-send-email-markus.t.metzger@intel.com> <1416480444-9943-6-git-send-email-markus.t.metzger@intel.com> X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00476.txt.bz2 > From: Markus Metzger > Cc: gdb-patches@sourceware.org, Eli Zaretskii > Date: Thu, 20 Nov 2014 11:47:16 +0100 > > Allow the size of the branch trace ring buffer to be defined by the > user. The specified buffer size will be used when BTS tracing is > enabled for new threads. > > The obtained buffer size may differ from the requested size. The > actual buffer size for the current thread is shown in the "info record" > command. > > Bigger buffers mean longer traces, but also longer processing time. > > CC: Eli Zaretskii > > 2014-11-20 Markus Metzger > > * btrace.c (parse_xml_btrace_conf_bts): Add size. > (btrace_conf_bts_attributes): New. > (btrace_conf_children): Add attributes. > * common/btrace-common.h (btrace_config_bts): New. > (btrace_config): New. > (btrace_config): Update comment. > * nat/linux-btrace.c (linux_enable_btrace): Use config. > * features/btrace-conf.dtd: Increment version. Add size > attribute to bts element. > * record-btrace.c (set_record_btrace_bts_cmdlist, > show_record_btrace_bts_cmdlist): New. > (record_btrace_adjust_size, record_btrace_print_bts_conf, > record_btrace_print_conf, cmd_set_record_btrace_bts, > cmd_show_record_btrace_bts): New. > (record_btrace_info): Call record_btrace_print_conf. > (_initialize_record_btrace): Add commands. > * remote.c: Add PACKET_Qbtrace_conf_bts_size enum. > (remote_protocol_features): Add Qbtrace-conf:bts:size packet. > (btrace_sync_conf): Synchronize bts size. > (_initialize_remote): Add Qbtrace-conf:bts:size packet. > * NEWS: Announce new commands and new packets. > > doc/ > * gdb.texinfo (Branch Trace Configuration Format): Add size. > (Process Record and Replay): Describe new set|show commands. > (General Query Packets): Describe Qbtrace-conf:bts:size packet. > > testsuite/ > * gdb.btrace/buffer-size: New. > > gdbserver/ > * linux-low.c (linux_low_btrace_conf): Print size. > * server.c (handle_btrace_conf_general_set): New. > (hanle_general_set): Call handle_btrace_conf_general_set. > (handle_query): Report Qbtrace-conf:bts:size as supported. OK for the documentation parts. Thanks.