From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8568 invoked by alias); 29 Oct 2011 16:01:00 -0000 Received: (qmail 8559 invoked by uid 22791); 29 Oct 2011 16:00:58 -0000 X-SWARE-Spam-Status: No, hits=-0.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB,SPF_SOFTFAIL,TW_BJ X-Spam-Check-By: sourceware.org Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 29 Oct 2011 16:00:42 +0000 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LTU00E0046K9W00@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Sat, 29 Oct 2011 18:00:40 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.128.216]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LTU00EJW4H39N10@a-mtaout23.012.net.il>; Sat, 29 Oct 2011 18:00:40 +0200 (IST) Date: Sat, 29 Oct 2011 19:48:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] Implement new `info core mappings' command In-reply-to: To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83sjmb949k.fsf@gnu.org> References: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00805.txt.bz2 > From: Sergio Durigan Junior > Cc: gdb-patches@sourceware.org > Date: Thu, 27 Oct 2011 15:55:34 -0200 > > Ok, thanks for the directions. I rewrote this part of the patch (see > below) to address all the comments. Please, let me know what you think. It is fine, except for a single gotcha: > +@smallexample > +(@value{GDBP}) info core mappings > +exe = '/tmp/a.out' > +Mapped address spaces: > + > + Start Addr End Addr Size objfile > + 0x400000 0x401000 0x1000 /tmp/a.out > + 0x600000 0x601000 0x1000 /tmp/a.out > + 0x397de00000 0x397de1f000 0x1f000 /usr/lib/debug/lib64/ld-2.13.so.debug > + 0x397e01e000 0x397e01f000 0x1000 /usr/lib/debug/lib64/ld-2.13.so.debug > + 0x397e01f000 0x397e020000 0x1000 /usr/lib/debug/lib64/ld-2.13.so.debug > + 0x397e020000 0x397e021000 0x1000 /usr/lib/debug/lib64/ld-2.13.so.debug > + 0x397e200000 0x397e391000 0x191000 /usr/lib/debug/lib64/libc-2.13.so.debug > + 0x397e591000 0x397e595000 0x4000 /usr/lib/debug/lib64/libc-2.13.so.debug > + 0x397e595000 0x397e596000 0x1000 /usr/lib/debug/lib64/libc-2.13.so.debug > + 0x397e596000 0x397e59c000 0x6000 > + 0x7ffff7fd1000 0x7ffff7fd4000 0x3000 > + 0x7ffff7ffd000 0x7ffff7ffe000 0x1000 > + 0x7ffff7ffe000 0x7ffff7fff000 0x1000 system-supplied DSO at 0x7ffff7ffe000 > + 0x7ffffffde000 0x7ffffffff000 0x21000 > + 0xffffffffff600000 0xffffffffff601000 0x1000 > +@end smallexample This is too wide for a @smallexample, and will overflow the page limits in print. We need to keep each line under 75 characters. So what I suggest is this: . Remove the lines with large addresses from the example, and maybe also the line whose "size" is 0x191000 . Delete as much white space between the columns as possible . If the above measures are not enough, shorten the file names of the libraries, e.g. /usr/lib/debug/libc.so.debug Okay with that change. Thanks.