From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6973 invoked by alias); 13 Dec 2010 17:46:30 -0000 Received: (qmail 6957 invoked by uid 22791); 13 Dec 2010 17:46:29 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 13 Dec 2010 17:46:23 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LDD00D00NX96F00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Mon, 13 Dec 2010 19:46:20 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.167.122]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LDD00DZ1O176H00@a-mtaout20.012.net.il>; Mon, 13 Dec 2010 19:46:20 +0200 (IST) Date: Mon, 13 Dec 2010 17:46:00 -0000 From: Eli Zaretskii Subject: Re: [patch] Add an evaluation function hook to Python breakpoints. In-reply-to: To: pmuldoon@redhat.com Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83sjy1h8gk.fsf@gnu.org> References: <8362uxiwmc.fsf@gnu.org> <83zks9hfsz.fsf@gnu.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00192.txt.bz2 > From: Phil Muldoon > Cc: gdb-patches@sourceware.org > Date: Mon, 13 Dec 2010 17:20:57 +0000 > > > So I would rephrase the text in question like this: > > > > If this function is defined in a sub-class of @code{gdb.Breakpoint}, > > it will be called when the inferior reaches any breakpoint which > > instantiates that sub-class. > > But only if the inferior has stopped at the location of that > breakpoint. That's why my suggested text says "when the inferior reaches any breakpoint". I thought it was clear that "reaching a breakpoint" means to get to the breakpoint's location. And when the inferior reaches the breakpoint's location, it inevitably stops, right? I don't mind making this more explicit, either: If this function is defined in a sub-class of @code{gdb.Breakpoint}, it will be called when the inferior stops at any location of a breakpoint which instantiates that sub-class.