From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=edRd=FA=gnu.org=eliz@sourceware.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
	by sourceware.org (Postfix) with ESMTPS id ACCA73858D33
	for <gdb-patches@sourceware.org>; Sat, 16 Sep 2023 08:50:37 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ACCA73858D33
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e])
	by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.90_1)
	(envelope-from <eliz@gnu.org>)
	id 1qhR0f-0007n5-2a; Sat, 16 Sep 2023 04:50:37 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
	s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
	Date; bh=gE1m95Y56ub7MHA5wo12ubLkRS05khBPZEFLkLPCUUw=; b=fA0cK2wKX8xOW+azu1j2
	5vwKlIiKrdR6Lq7aPh29Fy/Yitlwof2JuG98gr1iJ5sEwmj3nGx099mNqRd22eIjte6xf0BjwZ13g
	a6FkLtLxj3Ego0o0lTMpvELsL+xNYyCPc+VeP5UYOhoKoN2C0u0P3xgVlL4Im+71Yq7EKOibOXRZt
	yWIGDNEeE3e2VomYYhQM76SRyjMjzVWfYX/qjsJvkCH53eiiZd0XDKqWTqXQH7FXZoY7Y3TUj0I1N
	jQJ1WDa2k4lLEect8jcPrksMzbEsxD3g+nlQoihATZYP2cVNCfHYof2T8lpN8B2V9+M5EsxzLbdpQ
	Do2w6M8mQtvArQ==;
Date: Sat, 16 Sep 2023 11:50:30 +0300
Message-Id: <83ttruijs9.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Matt Rice <ratmice@gmail.com>
Cc: tom@tromey.com, gdb-patches@sourceware.org
In-Reply-To:
	<CACTLOFq2BBJkV2uj2=EtpDMY6zRLcW2jfVc22G+9LTJihBQY2A@mail.gmail.com>
	(message from Matt Rice on Sat, 16 Sep 2023 08:39:34 +0000)
Subject: Re: [PATCH] Support the NO_COLOR environment variable
References: <20230916000908.110459-1-tom@tromey.com> <83bke2k7fa.fsf@gnu.org> <CACTLOFq2BBJkV2uj2=EtpDMY6zRLcW2jfVc22G+9LTJihBQY2A@mail.gmail.com>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

> From: Matt Rice <ratmice@gmail.com>
> Date: Sat, 16 Sep 2023 08:39:34 +0000
> Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
> 
> On Sat, Sep 16, 2023 at 5:35 AM Eli Zaretskii via Gdb-patches
> <gdb-patches@sourceware.org> wrote:
> >
> > Should we also support the --color command-line argument, e.g. to
> > countermand NO_COLOR in the environment, and also as an alternative to
> > the environment variable?
> 
> I'm not sure a specific --color command-line argument is necessary,
> the arg --early-init-eval-command 'set style enabled' (-eiex, which I
> noticed is missing from --help.) works even when NO_COLOR is set,
> appropriately printing colors in the non-quiet startup message.  So
> even without something specific like --color it is possible to
> override the env var.

Since this is basically a compatibility feature, I thought that having
a related --color=WHEN command-line option would also be nice, for the
same reasons.  But if I'm the only one who thinks that, it's fine by
me not to have such an option.