From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id CE4733861872 for ; Mon, 13 Feb 2023 18:42:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CE4733861872 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRdmR-0008Ao-Ce; Mon, 13 Feb 2023 13:42:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=67xWj+OfzJtxZEIXD0bNCPvLCyhOhmPSBn1PIYKwLj4=; b=a0JRsO4zETkr GQLP9hDrE6pWgiv+zzrhXEPDkkXcrsLaHCihCkP8PoYya3+ufbrSsWQvHvnBkGHvkyWd9vTpKfcNF vZcz1c9UHmJrb3g1TzSHKfAQnnBQW+RUXdRMjKcZSeN79llyicliNZLBUTzqXcPsOIuFkag1eYMQ6 ttbKgV+sOSnElqdWQ0FdAGT8hDKOvOhkFCQ+rcwCCuS6V3elcxRdL4K3OMgWKKpcjEvC8T9J1HjxZ hgZ3lDd6Hd/dpJrolAIIcXQTWaSJM63eLyKEM+alPySH2ZLHxZR94ck/Y2MHA/iROIo6MyxCwDtwr 53mpke65tYkJJXGt+T0/HA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRdmQ-0007ju-0O; Mon, 13 Feb 2023 13:42:22 -0500 Date: Mon, 13 Feb 2023 20:41:59 +0200 Message-Id: <83ttzpe7bc.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves Cc: gdb-patches@sourceware.org In-Reply-To: <4867e243-13db-fe1a-3cf6-e31150e6d928@palves.net> (message from Pedro Alves on Mon, 13 Feb 2023 17:27:39 +0000) Subject: Re: [PATCH 3/6] Add new "$_shell(CMD)" internal function References: <20230210233604.2228450-1-pedro@palves.net> <20230210233604.2228450-4-pedro@palves.net> <83r0uwk4tm.fsf@gnu.org> <439ab6f5-ec2d-87ef-d84c-3ace9ead93a8@palves.net> <833579fugd.fsf@gnu.org> <4867e243-13db-fe1a-3cf6-e31150e6d928@palves.net> X-Spam-Status: No, score=1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: gdb-patches@sourceware.org > From: Pedro Alves > Date: Mon, 13 Feb 2023 17:27:39 +0000 > > > OK, with the above nits. > Would you mind taking another look? Here's what it looks like currently: Thanks, LGTM.