From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 6F5D63851C21
 for <gdb-patches@sourceware.org>; Sat, 28 May 2022 12:20:59 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6F5D63851C21
Received: from fencepost.gnu.org ([2001:470:142:3::e]:56130)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nuvRC-000853-5k; Sat, 28 May 2022 08:20:58 -0400
Received: from [87.69.77.57] (port=1221 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nuvRB-000491-KJ; Sat, 28 May 2022 08:20:57 -0400
Date: Sat, 28 May 2022 15:20:54 +0300
Message-Id: <83tu99luft.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: ptsneves@gmail.com
Cc: gdb-patches@sourceware.org
In-Reply-To: <20220528115509.3865342-2-ptsneves@gmail.com> (message from Paulo
 Neves via Gdb-patches on Sat, 28 May 2022 13:55:08 +0200)
Subject: Re: [PATCH 1/2] gdb/python doc: Add register_unwinder to code example
References: <gdb-patches@sourceware.org>
 <20220528115509.3865342-1-ptsneves@gmail.com>
 <20220528115509.3865342-2-ptsneves@gmail.com>
X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sat, 28 May 2022 12:21:01 -0000

> Date: Sat, 28 May 2022 13:55:08 +0200
> From: Paulo Neves via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Paulo Neves <ptsneves@gmail.com>
> 
> It is now clear in the example code that an unwinder needs to be
> registered to be used.
> ---
>  gdb/doc/python.texi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
> index cb5283e03c0..5b7fba798a9 100644
> --- a/gdb/doc/python.texi
> +++ b/gdb/doc/python.texi
> @@ -2814,6 +2814,8 @@ class MyUnwinder(Unwinder):
>          # Return the result:
>          return unwind_info
>  
> +# To use an unwinder it needs to be registered and enabled.
> +gdb.unwinder.register_unwinder (<locus>, MyUnwinder, replace=<True|False>)
>  @end smallexample

Thanks, I think this needs to be reviewed by someone who knows how to
program the Python unwinders.  As far as Texinfo is concerned, this is
fine.