From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 0DB8438346BE
 for <gdb-patches@sourceware.org>; Tue, 10 May 2022 14:04:48 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0DB8438346BE
Received: from fencepost.gnu.org ([2001:470:142:3::e]:45442)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1noQTn-00036U-IN; Tue, 10 May 2022 10:04:47 -0400
Received: from [87.69.77.57] (port=2736 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1noQTn-0005LO-1z; Tue, 10 May 2022 10:04:47 -0400
Date: Tue, 10 May 2022 17:04:45 +0300
Message-Id: <83tu9xscua.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: "Willgerodt, Felix" <felix.willgerodt@intel.com>
Cc: markus.t.metzger@intel.com, gdb-patches@sourceware.org
In-Reply-To: <MN2PR11MB456683FEF3336DF28F80743E8EC99@MN2PR11MB4566.namprd11.prod.outlook.com>
 (felix.willgerodt@intel.com)
Subject: Re: [PATCH v4 06/10] python: Add clear() to gdb.Record.
References: <20220506114010.134106-1-felix.willgerodt@intel.com>
 <20220506114010.134106-6-felix.willgerodt@intel.com> <83a6bu282n.fsf@gnu.org>
 <MN2PR11MB456683FEF3336DF28F80743E8EC99@MN2PR11MB4566.namprd11.prod.outlook.com>
X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 10 May 2022 14:04:50 -0000

> From: "Willgerodt, Felix" <felix.willgerodt@intel.com>
> CC: "Metzger, Markus T" <markus.t.metzger@intel.com>,
> 	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> Date: Tue, 10 May 2022 13:42:49 +0000
> 
> > > +@defun Record.clear ()
> > > +Clear the trace data of the current recording.  This forces re-decoding of
> > the
> > > +trace for successive commands.
> > > +@end defun
> > 
> > What does "force re-decoding" mean here? 
> 
> The recorded instructions and pt packets will be discarded. "Re-decoding"
> means that the pt buffer will be re-read and re-decoded by GDB/libipt
> into a new instruction history.

Does saying that help users in any way?  If not, maybe just remove
that part?

> > If this is described in
> > another place in the manual, could you add a cross-reference to that
> > place?
> > 
> 
> I don't think it has been described yet, as clear() hasn't directly been exposed
> before, only indirectly e.g. via "record stop". The "trace" is however
> mentioned e.g. here for "record btrace pt":
> https://sourceware.org/gdb/onlinedocs/gdb/Process-Record-and-Replay.html
> 
> Should I link that?

Yes, I think so.