From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-118861-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15976 invoked by alias); 8 Jan 2015 14:58:34 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 15964 invoked by uid 89); 8 Jan 2015 14:58:33 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout20.012.net.il
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Jan 2015 14:58:31 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NHV00C005JD1Z00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Thu, 08 Jan 2015 16:58:29 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NHV00BWG5LGE9B0@a-mtaout20.012.net.il>; Thu, 08 Jan 2015 16:58:29 +0200 (IST)
Date: Thu, 08 Jan 2015 14:58:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 1/3] Remove superfluous function key_is_command_char()
In-reply-to: <CA+C-WL_F-VD2Z0mY2WEjW1zGayz9aw0CYFZGuWRfr6c5+ww_yQ@mail.gmail.com>
To: Patrick Palka <patrick@parcs.ath.cx>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83tx015nfg.fsf@gnu.org>
References: <1420689885-31156-1-git-send-email-patrick@parcs.ath.cx> <83zj9t5rbe.fsf@gnu.org> <CA+C-WL_F-VD2Z0mY2WEjW1zGayz9aw0CYFZGuWRfr6c5+ww_yQ@mail.gmail.com>
X-IsSubscribed: yes
X-SW-Source: 2015-01/txt/msg00195.txt.bz2

> From: Patrick Palka <patrick@parcs.ath.cx>
> Date: Thu, 8 Jan 2015 08:47:44 -0500
> Cc: gdb-patches@sourceware.org
> 
> > But tui_dispatch_ctrl_char punts when the current window is the
> > command window, doesn't it?  This means we are losing the possibility
> > to handle command keys in the command window.
> 
> I don't see how that follows.  If the current window is the command
> window then dispatch_ctrl_char() returns the input character
> unmodified.  So the behavior after the patch is the same as if the
> call to dispatch_ctrl_char() was guarded by the key_is_command_char()
> predicate, before the patch.

Sorry, you are right.