From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-118405-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24347 invoked by alias); 16 Dec 2014 03:40:06 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 24333 invoked by uid 89); 16 Dec 2014 03:40:05 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout26.012.net.il
Received: from mtaout26.012.net.il (HELO mtaout26.012.net.il) (80.179.55.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Dec 2014 03:40:04 +0000
Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0NGN00G00OIJ3K00@mtaout26.012.net.il> for gdb-patches@sourceware.org; Tue, 16 Dec 2014 05:39:07 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NGN00F5POT7VE10@mtaout26.012.net.il>; Tue, 16 Dec 2014 05:39:07 +0200 (IST)
Date: Tue, 16 Dec 2014 03:40:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch] compile: Fix MinGW build  [Re: [mingw rfc] Add mkdtemp to gdb/gnulib/]
In-reply-to: <20141215225551.GA28880@host2.jankratochvil.net>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: brobecker@adacore.com, yao@codesourcery.com, gdb-patches@sourceware.org, ktietz@redhat.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83tx0ww9dl.fsf@gnu.org>
References: <20141214182341.GA2908@host2.jankratochvil.net> <87a92pvc0w.fsf@codesourcery.com> <20141215124358.GU5457@adacore.com> <20141215171225.GA19674@host2.jankratochvil.net> <20141215181449.GA5457@adacore.com> <20141215182057.GA22226@host2.jankratochvil.net> <20141215183554.GB5457@adacore.com> <20141215184014.GA22610@host2.jankratochvil.net> <83y4q8wxk7.fsf@gnu.org> <20141215222801.GA28138@host2.jankratochvil.net> <20141215225551.GA28880@host2.jankratochvil.net>
X-IsSubscribed: yes
X-SW-Source: 2014-12/txt/msg00438.txt.bz2

> Date: Mon, 15 Dec 2014 23:55:51 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: brobecker@adacore.com, yao@codesourcery.com, gdb-patches@sourceware.org,
>         ktietz@redhat.com
> 
> On Mon, 15 Dec 2014 23:28:01 +0100, Jan Kratochvil wrote:
> > The 'compile' project needs a larger port effort to run on MS-Windows.
> 
> For example there is also
> 
> compile/compile.c:
>   zap = concat ("rm -rf ", dir, (char *) NULL);
>   system (zap);

Yuck!  Do we really allow such atrocities in GDB?  What if 'rm' is
some unrelated or even malicious script?

I think this should be replaced by suitable C function calls.  IMO,
this kind of programming is OK for prototyping, but not for the final
code.