From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id D5E743858D1E for ; Tue, 7 Nov 2023 19:41:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D5E743858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D5E743858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699386095; cv=none; b=ml9E7F4pVR3bArO4dfYnhK4qPQKElGQSK1z4eVDYlw9cFZt049RB7bLAdYObK1jhS86JhqjFylw9/dZhplgUCzGTdO4YbaR/0WRDUKwlZIkNtxMaFybeagseVB5R1h61MqCN3r0wZPbGIglakiybUNXseiMlcsNOUdiPpg1ohJw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699386095; c=relaxed/simple; bh=ZauSB1p3uDqpL/129EF0boVaU1pGw5en/6QRWNwGcgI=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=WNsG8I/xKV593ZFr1r9az+O6D0425iagKY7y3Y76hB6u1YV1k7DI+K0r6uOoUsN0bzsfS7tEvo+ccBmyHqJdrpPyFr6hHVP3FW2+syFShUWGVE9RmwXaMzWi69da2TCQJxSQPRrFi9gKTd+NKre36gW7WOnBvgqsdyxhNu6nQU0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0Rx7-0003O6-A8; Tue, 07 Nov 2023 14:41:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Pto8sqL+tHccSC4AZ5JKXsvK+NQEJ07isQ+qns4wzHc=; b=MPK5deAWpQPy R/cTJXAoyrxeX1fXpA96BOMRa23MGLEFCNAKvLr+qXDBWy2jX5rh9ayHFlJtKxzB9QHA1/0T4Hpp+ Td0+s5l0GxQhjVF9rcvJl0YbJpRq9In/VmVeZd3Vgk4InbJ1k7SZaf/Hun5neRMv/OQjX8F5HceZ+ wDOaZnB5zSJgN3SGDWMeBfxN8q6PsJ907Cm0AFeZWk/8k8UEoNEZ6b0ZwbKcT2hyQ7Lkj1o8PFKEA pgDtY/w9+QtibTPfR4OCtHJiZkbx6q590qY7mHBRAPhu9YJ0rzFCv2TNVtuCxqRzMlPxZokJM5XZs mXP2dKkgkVxkP8LQmTcWEA==; Date: Tue, 07 Nov 2023 21:41:20 +0200 Message-Id: <83v8ad1hcv.fsf@gnu.org> From: Eli Zaretskii To: Andrew Burgess Cc: gdb-patches@sourceware.org, aburgess@redhat.com In-Reply-To: (message from Andrew Burgess on Tue, 7 Nov 2023 18:03:22 +0000) Subject: Re: [PATCH 2/3] gdbserver: allow the --debug command line option to take a value References: X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Andrew Burgess > Cc: Andrew Burgess > Date: Tue, 7 Nov 2023 18:03:22 +0000 > > gdb/NEWS | 7 ++++ > gdb/doc/gdb.texinfo | 62 +++++++++++++++++++++++---- > gdbserver/server.cc | 100 ++++++++++++++++++++++++++++++++++++++++++-- > 3 files changed, 156 insertions(+), 13 deletions(-) Thanks. > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -6,6 +6,13 @@ > * GDB index now contains information about the main function. This speeds up > startup when it is being used for some large binaries. > > +* New features in the GDB remote stub, GDBserver > + > + ** The `--debug` option now takes an (optional) list of components ^^^^^^^^^ That's not how we quote in plain-ASCII documentation. (And I think we don't need quoting here anyway.) > @cindex @option{--debug}, @code{gdbserver} option > -The @option{--debug} option tells @code{gdbserver} to display extra > -status information about the debugging process. > +The @option{--debug[=option1,option2,...]} option tells ^^^ Please use @dots{} instead of literally 3 dots. > +@code{gdbserver} to display extra diagnostic information about the > +debugging process. The @var{option1}, @var{option2}, etc control for ^^^ "etc.@:" > +@item remote > +This enables diagnostic output relating to the transfer of remote ^^^^^^^^ "related" > -@item --debug > +@item --debug@r{[}=option1,option2,...@r{]} ^^^ @dots{} > +Each @var{option} is the name of a component for which debugging > +should be enabled. The list of possible options is @option{all}, > +@option{threads}, @option{event-loop}, @option{remote}. The special > +option @option{all} enables all components. The option list is > +processed left to right, and an option can be prefixed with the > +@kbd{-} character to disable output for that component, so you could write: > + > +@smallexample > +target> gdbserver --debug=all,-event-loop > +@end smallexample > + > +@noindent to turn on debug output for all components except @option{event-loop}. Why do we need this duplicate description? I'd prefer to have a short sentence with a cross-reference to the previous description, so that we could have only one of them, not two. Reviewed-By: Eli Zaretskii