From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 7/8] Add new Python APIs to support DAP value display
Date: Tue, 22 Aug 2023 18:46:16 +0300 [thread overview]
Message-ID: <83v8d7rsfr.fsf@gnu.org> (raw)
In-Reply-To: <20230822-array-and-string-like-v1-7-2dcea29b0567@adacore.com> (message from Tom Tromey via Gdb-patches on Tue, 22 Aug 2023 09:25:13 -0600)
> Date: Tue, 22 Aug 2023 09:25:13 -0600
> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
>
> gdb's language code may know how to display values specially. For
> example, the Rust code understands that &str is a string-like type, or
> Ada knows how to handle unconstrained arrays. This knowledge is
> exposed via val-print, and via varobj -- but currently not via DAP.
>
> This patch adds some support code to let DAP also handle these cases,
> though in a somewhat more generic way.
>
> Type.is_array_like and Value.to_array are added to make Python aware
> of the cases where gdb knows that a structure type is really
> "array-like".
>
> Type.is_string_like is added to make Python aware of cases where gdb's
> language code knows that a type is string-like.
>
> Unlike Value.string, these cases are handled by the type's language,
> rather than the current language.
> ---
> gdb/NEWS | 8 ++++++++
> gdb/doc/python.texi | 24 ++++++++++++++++++++++
> gdb/python/py-type.c | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++
> gdb/python/py-value.c | 37 +++++++++++++++++++++++++++++++++
> 4 files changed, 126 insertions(+)
Thanks, the documentation parts are okay.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2023-08-22 15:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 15:25 [PATCH 0/8] Handle array- and string-like types in DAP Tom Tromey
2023-08-22 15:25 ` [PATCH 1/8] Move rust_language::lookup_symbol_nonlocal Tom Tromey
2023-08-22 15:25 ` [PATCH 2/8] Refactor Rust code for slice-to-array operation Tom Tromey
2023-08-22 15:25 ` [PATCH 3/8] Introduce TYPE_SPECIFIC_RUST_STUFF Tom Tromey
2023-08-22 15:25 ` [PATCH 4/8] Use ada_value_subscript in valpy_getitem Tom Tromey
2023-08-22 15:25 ` [PATCH 5/8] Introduce type::is_array_like and value_to_array Tom Tromey
2023-08-22 15:25 ` [PATCH 6/8] Select frame when fetching a frame variable in DAP Tom Tromey
2023-08-22 15:25 ` [PATCH 7/8] Add new Python APIs to support DAP value display Tom Tromey
2023-08-22 15:46 ` Eli Zaretskii [this message]
2023-08-22 15:25 ` [PATCH 8/8] Handle array- and string-like values in no-op pretty printers Tom Tromey
2023-09-05 17:22 ` [PATCH 0/8] Handle array- and string-like types in DAP Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v8d7rsfr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).