From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 49F393857012 for ; Wed, 12 Apr 2023 09:54:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 49F393857012 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmXB9-0002yj-8h; Wed, 12 Apr 2023 05:54:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xpwUZpN/uYbyD6C9doY0vd6qQO594SPJLWytMxnL6KE=; b=ImQJ3FOc9Yp4 ArBktKldxiXl771OHE6C2JULcIcdZ3/58KekUm3nMB1s9rrtR0z95GNjgIPyOH1Mb+6fR+iLKidU0 6kOKmvrecuBAIrzeRTZonjzLrot6KsW/J1iaA8/RHvLNbLgZnLOoHJ4juRKFDMoOAc0XjTHQqSt6f BL6oYbHnEVRFTTh3LNFIA1V5ZowBKGqCnGy7IG/eQ98uGi7se9dQ5pq9TcBJP0LYd2V7YSza9Kcj6 L8RXDhpBAhN4+ekifxbPL+o6Li57+vl2js1UNGIC97o0LlXccLJxlPnKBgHE/4G5dNs5Sq3fAD43E By4JQ/baoHXz1WARdoId3g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmXB8-0004xe-Gv; Wed, 12 Apr 2023 05:54:14 -0400 Date: Wed, 12 Apr 2023 12:54:59 +0300 Message-Id: <83v8i177d8.fsf@gnu.org> From: Eli Zaretskii To: Luis Machado Cc: gdb-patches@sourceware.org, alex.bennee@linaro.org, richard.henderson@linaro.org, peter.maydell@linaro.org In-Reply-To: <9ae7c1bd-64d3-7444-fbc7-e536f8b2f971@arm.com> (message from Luis Machado on Wed, 12 Apr 2023 10:25:56 +0100) Subject: Re: [PATCH] [gdb/aarch64] pauth: Create new feature string for pauth to prevent crashing older gdb's References: <20230411224327.2142994-1-luis.machado@arm.com> <83mt3d8wkf.fsf@gnu.org> <63c2cf2c-692c-7737-d0ee-b8cb30439b4c@arm.com> <831qkp8nin.fsf@gnu.org> <9ae7c1bd-64d3-7444-fbc7-e536f8b2f971@arm.com> X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Date: Wed, 12 Apr 2023 10:25:56 +0100 > Cc: gdb-patches@sourceware.org, alex.bennee@linaro.org, > richard.henderson@linaro.org, peter.maydell@linaro.org > From: Luis Machado > > > The flow is OK, but the last paragraph is too long. The main reason > > of this text is to tell people to use the v2 feature, not to explain > > why it exists. So the explanation of the reason should be shorter > > like > > Though it is documentation for users, it is also one of the only documents providing guidance for developers of debugging stubs (like QEMU's, openOCD etc). > > So I feel like it should include a bit more information rather than the bare minimum. > > I don't think this particular section (XML target descriptions) is geared towards the common debugger users. > > > > > We recommend always using the @samp{org.gnu.gdb.aarch64.pauth_v2} > > feature because using @samp{org.gnu.gdb.aarch64.pauth} could crash > > older versions of @value{GDBN} due to a known bug in those versions. > > I think the above is sane. It just has less detail, which, as explained above, might not be too useful for > developers of debugging stubs. > > > > > Is it really important to say that the bug happens only when > > additional system registers are reported? > > We could make it shorter by only mentioning this is only an issue when using emulators. Fine by me, thanks.