From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id F022D3858C53 for ; Thu, 30 Mar 2023 14:08:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F022D3858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phsxF-0000QL-4L; Thu, 30 Mar 2023 10:08:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XpVrfrhiXfwZ/xm1zYOjztMdIdh+nU7O1Z5d+HqrhQU=; b=V/ZP/LDEgSd+ Pjyjys0nF1yyKE5BhEg6QklPS/z7q0UugWBdCBRDyZyiGMIHv9LH9wQAQg+/8saWpc0a9p/9/vChy vwADFIRtCjn3cfCt/b0m0h1Uf8d9TYKtC0tWjVVLBTvIebStRA6ynJI7fGiNoDaulv4MitZURWstY Jc81pM+oH0q5LqcM9fA9GTzAW1ZADe/ipkCAHg/KB38i7tSkH9+3sjqYr34z1jHMRsq88MZtLbE9J IStxx2FFdIWwMlnJ5IzoSAHE36uM23S0gJ1Equ1f+hQb1hHnScHwvIEtGZaonE0LOexD3/spDITwy Djjg2Dk5lU2d4fERZPK6iQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phsxE-0004db-Ky; Thu, 30 Mar 2023 10:08:40 -0400 Date: Thu, 30 Mar 2023 17:08:50 +0300 Message-Id: <83v8ii49hp.fsf@gnu.org> From: Eli Zaretskii To: Andrew Burgess Cc: gdb-patches@sourceware.org In-Reply-To: <0d08cca8737eff64400b5bb973bed259e4affa7e.1680177890.git.aburgess@redhat.com> (message from Andrew Burgess via Gdb-patches on Thu, 30 Mar 2023 13:10:20 +0100) Subject: Re: [PATCH 1/4] gdb/python: have UnwindInfo.add_saved_register accept named args References: <0d08cca8737eff64400b5bb973bed259e4affa7e.1680177890.git.aburgess@redhat.com> X-Spam-Status: No, score=1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: Andrew Burgess > Date: Thu, 30 Mar 2023 13:10:20 +0100 > From: Andrew Burgess via Gdb-patches > > --- a/gdb/doc/python.texi > +++ b/gdb/doc/python.texi > @@ -2882,8 +2882,8 @@ > create a @code{gdb.UnwindInfo} instance. Use the following method to > specify caller registers that have been saved in this frame: > > -@defun gdb.UnwindInfo.add_saved_register (reg, value) > -@var{reg} identifies the register, for a description of the acceptable > +@defun gdb.UnwindInfo.add_saved_register (@var{register}, @var{value}) > +@var{register} identifies the register, for a description of the acceptable > values see @ref{gdbpy_frame_read_register,,Frame.read_register}. > @var{value} is a register value (a @code{gdb.Value} object). > @end defun Why did you use @var inside the argument list on a @defun line? That shouldn't be necessary, and the original text didn't use that. Otherwise, this is okay (although the change just modifies the name of a single argument, so I'm not sure why we are doing this). Thanks. Reviewed-By: Eli Zaretskii