From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 778893858C39
 for <gdb-patches@sourceware.org>; Wed,  3 Aug 2022 19:16:28 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 778893858C39
Received: from fencepost.gnu.org ([2001:470:142:3::e]:53440)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1oJJr0-00047a-C6; Wed, 03 Aug 2022 15:16:26 -0400
Received: from [87.69.77.57] (port=2877 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1oJJqz-0004yo-K7; Wed, 03 Aug 2022 15:16:26 -0400
Date: Wed, 03 Aug 2022 22:16:21 +0300
Message-Id: <83v8r93zp6.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <87les5go5f.fsf@tromey.com> (message from Tom Tromey on Wed, 03
 Aug 2022 12:47:24 -0600)
Subject: Re: [PATCH 1/2] Move some Windows operations to worker thread
References: <20220803130822.735057-1-tromey@adacore.com>
 <20220803130822.735057-2-tromey@adacore.com> <83a68l5u4h.fsf@gnu.org>
 <87les5go5f.fsf@tromey.com>
X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Aug 2022 19:16:29 -0000

> From: Tom Tromey <tromey@adacore.com>
> Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
> Date: Wed, 03 Aug 2022 12:47:24 -0600
> 
> >> +  HANDLE bg_thread = CreateThread (nullptr, 0, fn, this, 0, nullptr);
> 
> Eli> That zero in the 2nd argument of CreateThread means the worker thread
> Eli> will get the same stack size as the value recorded in the GDB
> Eli> executable file's header, which is 12MB according to my reading of
> Eli> gdb/Makefile, at least in my build?  That's unlikely to be required
> Eli> for this thread, so I suggest to specify a non-zero value there
> Eli> instead.  I guess 64KB should be enough?
> 
> I changed it to `64 * 1024` and re-tested, and this worked ok.

Thanks.