public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Kevin Buettner <kevinb@redhat.com>
Cc: pedro@palves.net, simark@simark.ca, gdb-patches@sourceware.org
Subject: Re: [PATCH] set/show python dont-write-bytecode fixes
Date: Fri, 22 Jul 2022 09:40:07 +0300	[thread overview]
Message-ID: <83v8rplkfs.fsf@gnu.org> (raw)
In-Reply-To: <20220721160832.3a1d4b3c@f35-zws-1> (message from Kevin Buettner via Gdb-patches on Thu, 21 Jul 2022 16:08:32 -0700)

> Date: Thu, 21 Jul 2022 16:08:32 -0700
> From: Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
> 
> @@ -2346,11 +2353,11 @@ python executable."),
>  
>    add_setshow_auto_boolean_cmd ("dont-write-bytecode", no_class,
>  				&python_dont_write_bytecode, _("\
> -Set whether the Python interpreter should ignore environment variables."), _(" \
> -Show whether the Python interpreter showlist ignore environment variables."), _(" \
> -When enabled GDB's Python interpreter will ignore any Python related\n	\
> -flags in the environment.  This is equivalent to passing `-E' to a\n	\
> -python executable."),
> +Set whether the Python interpreter won't byte-compile python modules."), _("\
> +Show whether the Python interpreter won't byte-compile python modules."), _("

"Set whether ... won't byte-compile" is a kind-of double negation.
How about

 Set whether the Python interpreter should avoid byte-compiling python modules.

instead (and similar change in the "Show" line)?

> +When enabled GDB's Python interpreter won't byte-compile python modules.\n\
               ^
Comma missing there.

> +In order to take effect, this setting must be enabled before python\n\
> +initialization."),

Will GDB users understand clearly what that means in practical terms?
Should we say instead "before invoking the Python interpreter for the
first time"?

Finally should we mention the PYTHONDONTWRITEBYTECODE environment
variable?

Thanks.

  reply	other threads:[~2022-07-22  6:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 19:14 Kevin Buettner
2022-07-21 17:55 ` Pedro Alves
2022-07-21 23:08   ` Kevin Buettner
2022-07-22  6:40     ` Eli Zaretskii [this message]
2022-07-23  1:37       ` Kevin Buettner
2022-07-23  6:54         ` Eli Zaretskii
2022-07-23 21:30           ` Kevin Buettner
2022-07-24  5:41             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83v8rplkfs.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=pedro@palves.net \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).