From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id C9B5E3835839
 for <gdb-patches@sourceware.org>; Fri, 22 Jul 2022 06:40:15 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C9B5E3835839
Received: from fencepost.gnu.org ([2001:470:142:3::e]:38998)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1oEmKc-0001OI-NA; Fri, 22 Jul 2022 02:40:14 -0400
Received: from [87.69.77.57] (port=1895 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1oEmKc-0000ea-5s; Fri, 22 Jul 2022 02:40:14 -0400
Date: Fri, 22 Jul 2022 09:40:07 +0300
Message-Id: <83v8rplkfs.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Kevin Buettner <kevinb@redhat.com>
Cc: pedro@palves.net, simark@simark.ca, gdb-patches@sourceware.org
In-Reply-To: <20220721160832.3a1d4b3c@f35-zws-1> (message from Kevin Buettner
 via Gdb-patches on Thu, 21 Jul 2022 16:08:32 -0700)
Subject: Re: [PATCH] set/show python dont-write-bytecode fixes
References: <20220720191447.1014407-1-kevinb@redhat.com>
 <96a7e665-5700-349c-dfc5-50e59ab78fa5@palves.net>
 <20220721160832.3a1d4b3c@f35-zws-1>
X-Spam-Status: No, score=1.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jul 2022 06:40:16 -0000

> Date: Thu, 21 Jul 2022 16:08:32 -0700
> From: Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
> 
> @@ -2346,11 +2353,11 @@ python executable."),
>  
>    add_setshow_auto_boolean_cmd ("dont-write-bytecode", no_class,
>  				&python_dont_write_bytecode, _("\
> -Set whether the Python interpreter should ignore environment variables."), _(" \
> -Show whether the Python interpreter showlist ignore environment variables."), _(" \
> -When enabled GDB's Python interpreter will ignore any Python related\n	\
> -flags in the environment.  This is equivalent to passing `-E' to a\n	\
> -python executable."),
> +Set whether the Python interpreter won't byte-compile python modules."), _("\
> +Show whether the Python interpreter won't byte-compile python modules."), _("

"Set whether ... won't byte-compile" is a kind-of double negation.
How about

 Set whether the Python interpreter should avoid byte-compiling python modules.

instead (and similar change in the "Show" line)?

> +When enabled GDB's Python interpreter won't byte-compile python modules.\n\
               ^
Comma missing there.

> +In order to take effect, this setting must be enabled before python\n\
> +initialization."),

Will GDB users understand clearly what that means in practical terms?
Should we say instead "before invoking the Python interpreter for the
first time"?

Finally should we mention the PYTHONDONTWRITEBYTECODE environment
variable?

Thanks.