From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 1C4223857BBD
 for <gdb-patches@sourceware.org>; Thu,  2 Jun 2022 16:03:59 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1C4223857BBD
Received: from fencepost.gnu.org ([2001:470:142:3::e]:33976)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nwnIj-0000mt-8K; Thu, 02 Jun 2022 12:03:57 -0400
Received: from [87.69.77.57] (port=2824 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nwnIi-0007Qt-Nv; Thu, 02 Jun 2022 12:03:57 -0400
Date: Thu, 02 Jun 2022 19:04:05 +0300
Message-Id: <83v8tjdpca.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Jon Turney <jon.turney@dronecode.org.uk>
Cc: gdb-patches@sourceware.org
In-Reply-To: <a3e4dfab-d458-920e-f59e-e1fe7bca33bf@dronecode.org.uk> (message
 from Jon Turney on Thu, 2 Jun 2022 15:12:48 +0100)
Subject: Re: [PATCH 1/9] Fix possible Cygwin build problem
References: <20220413191756.1146768-1-tromey@adacore.com>
 <20220413191756.1146768-2-tromey@adacore.com>
 <a5624e79-c96a-120d-a568-66868d1671ea@dronecode.org.uk>
 <83sfp383t5.fsf@gnu.org> <87zgj46xfm.fsf@tromey.com> <83mtf4nmij.fsf@gnu.org>
 <a3e4dfab-d458-920e-f59e-e1fe7bca33bf@dronecode.org.uk>
X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jun 2022 16:04:00 -0000

> Date: Thu, 2 Jun 2022 15:12:48 +0100
> From: Jon Turney <jon.turney@dronecode.org.uk>
> 
> >> Yeah, I think __USEWIDE is not used for mingw.  However I wonder if we
> >> could remove it for Cygwin as well... that would clean up some code.
> >> Not a huge amount, but every Cygwin divergence is a bit of a pain.
> > 
> > This will need a Cygwin expert, which I'm not.
> 
> I think that would be a step backwards.
> 
> The reasons for this code seem to have been discussed, back when it was 
> added [1].
> 
> I think we must use the *W() API variants on cygwin, so that the paths 
> can be losslessly converted char * encoded in cygwin's conception of the 
> locale (which is not the Windows codepage, and may not be representable 
> as one).

I don't think Tom was suggesting to remove the *W APIs, I think he was
asking about removing the __USEWIDE thing.  Is it really necessary for
Cygwin to use the *W APIs?