From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id A48B53857340
 for <gdb-patches@sourceware.org>; Fri, 22 Apr 2022 08:30:13 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A48B53857340
Received: from fencepost.gnu.org ([2001:470:142:3::e]:53706)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nhog8-00052v-OC; Fri, 22 Apr 2022 04:30:12 -0400
Received: from [87.69.77.57] (port=2020 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nhog0-0002do-8i; Fri, 22 Apr 2022 04:30:12 -0400
Date: Fri, 22 Apr 2022 11:30:02 +0300
Message-Id: <83v8v1plkl.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Luis Machado <luis.machado@arm.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <f46481d7-0eef-7433-711c-f969a6bcb202@arm.com> (message from Luis
 Machado on Fri, 22 Apr 2022 09:12:44 +0100)
Subject: Re: [PATCH, v2] [AArch64] MTE corefile support
References: <20220331140343.9047-1-luis.machado@arm.com>
 <20220421152040.128278-1-luis.machado@arm.com> <83pmlaqvrl.fsf@gnu.org>
 <f46481d7-0eef-7433-711c-f969a6bcb202@arm.com>
X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Apr 2022 08:30:15 -0000

> Date: Fri, 22 Apr 2022 09:12:44 +0100
> Cc: gdb-patches@sourceware.org
> From: Luis Machado <luis.machado@arm.com>
> 
> >>   *** Changes since GDB 12
> >>   
> >> +* GDB now supports dumping memory tag data for AArch64 MTE.  It also supports
> >> +  reading memory tag data for AArch64 MTE from core files generated by
> >> +  the gcore command or the Linux kernel.
> >> +
> > 
> > I think this should say something about the significance of this
> > feature.  Otherwise it is completely unclear why would GDB want to
> > support that.
> > 
> > Same comment for the addition to the manual.
> > 
> > Thanks.
> 
> It is a bit short. How about the following additional paragraph?
> 
> "When a process uses memory-mapped pages protected by memory tags (for 
> example, AArch64 MTE), this additional information will be recorded in 
> the core file in the event of a crash or if GDB generates a core file 
> from the current process state.
> 
> The memory tag data will be used so developers can display the memory 
> tags from a particular memory region, and will also be used to show a 
> detailed message about a crash that happened due to a memory tag violation."

This is fine, but can what's described in the last paragraph be done
by GDB commands, or does it require external tools?  In the former
case, we should mention those GDB commands; in the latter case I'd
settle for mentioning the fact that external tools are required.

Thanks.