Re: [PATCH 4/4] gdb/mi: extend -file-list-exec-source-files command

[Eli Zaretskii <eliz@gnu.org>]

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Mon, 26 Apr 2021 18:07:03 +0100
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -31,6 +31,17 @@
>      equivalent of the CLI's "break -qualified" and "dprintf
>      -qualified".
>  
> +  ** '-file-list-exec-source-files' can now accept a regular
> +     expression for filtering, and accepts the flags --dirname,
> +     --basename and --group-by-binary, making this command equivalent
> +     of the cli 'info sources' command.
> +
> +     In the non '--group-by-binary' mode an extra field
> +     'debug-fully-read' has been added to each source file tuple to
> +     indicate if the debug information for the compilation unit
> +     containing this source file has been fully read or not, the
> +     values for this field are 'true' or 'false'.

This part is OK.

> +With no arguments this command returns a list of source files.  Each
> +source file is represented by a tuple with the fields; @var{file},
> +@var{fullname}, and @var{debug-fully-read}.  The @var{file} is the
> +display name for the file, while @var{fullname} is the absolute path
> +to the file.                                           ^^^^^^^^^^^^^
   ^^^^^^^^^^^
GNU Coding Standards frown on calling "path" anything that is not a
PATH-style directory list.  Please use "absolute name of the file"
instead.

>                The @var{fullname} field can be elided if the absolute
> +path to the source file can't be computed.

Likewise.

> +If @code{--dirname} is provided then @var{regexp} is matched only
> +against the directory name of each source file.  If @code{--basename}
> +is provided then @var{regexp} is matched against the source files
> +basename.
   ^^^^^^^^
"basenames", in plural.

> +If @code{--group-by-binary} is used then the format of the results is
> +changed.  The results will now be a list of tuples, with each tuple
> +representing an object file (executable or shared libraries) loaded
> +into @value{GDBN}.  The fields of these tuples are; @var{filename},
> +@var{debug-fully-read}, and @var{sources}.  The @var{filename} is the
> +absolute path to the object file, @var{debug-fully-read} is a string,
   ^^^^^^^^^^^^^
"path" again

Thanks.