From: Eli Zaretskii <eliz@gnu.org>
To: Doug Evans <xdje42@gmail.com>
Cc: palves@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] Speed up "gdb -tui" output
Date: Sat, 31 Jan 2015 21:37:00 -0000 [thread overview]
Message-ID: <83vbjnjpfb.fsf@gnu.org> (raw)
In-Reply-To: <CAP9bCMQ82dTHdN-w8hACOYGcus6oaMNNWpAhpQtLFhT4fnbQ5w@mail.gmail.com>
> Date: Mon, 19 Jan 2015 10:32:48 -0800
> From: Doug Evans <xdje42@gmail.com>
> Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
>
> On Mon, Jan 19, 2015 at 9:55 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> >> From: Doug Evans <dje@google.com>
> >> Date: Wed, 7 Jan 2015 13:59:06 -0800
> >>
> >> Doug Evans writes:
> >> > Seems like the main source of the problem would be gdb_stdout,
> >> > so let's try to fix that first and go from there.
> >>
> >> Here's a prototype.
> >
> > Sorry for a long delay. I tried this (and Pedro's) patch today. They
> > both do the job, so one of them should IMO be committed, master and
> > branch.
> >
> >> @@ -239,6 +243,12 @@ tui_file_flush (struct ui_file *file)
> >> case astring:
> >> break;
> >> case afile:
> >> + /* There is also gdb_stdlog, gdb_stdtarg, gdb_stdtargerr, but
> >> + tui_setup_io maps those to gdb_stderr. OTOH, do we need to make
> >> + this conditional? */
> >> + if (file == gdb_stdout
> >> + || file == gdb_stderr)
> >> + tui_refresh_cmd_win ();
> >
> > I indeed think that the condition should be removed. I see no need
> > for it: there's no reason to make any stream displayed on TUI more
> > than line-buffered.
>
> I don't have a preference on which, with one condition.
> If we're going to remove the fflush's let's do it as a separate patch.
Ping! Can one of these patches be committed, please, master and the
7.9 branch?
next prev parent reply other threads:[~2015-01-31 8:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 16:12 Eli Zaretskii
2015-01-06 18:37 ` Doug Evans
2015-01-06 19:06 ` Eli Zaretskii
2015-01-06 20:54 ` Doug Evans
2015-01-07 18:30 ` Eli Zaretskii
2015-01-07 19:08 ` Doug Evans
2015-01-07 19:20 ` Eli Zaretskii
2015-01-07 19:30 ` Doug Evans
2015-01-07 19:48 ` Eli Zaretskii
2015-01-07 20:45 ` Doug Evans
2015-01-07 21:59 ` Doug Evans
2015-01-19 17:55 ` Eli Zaretskii
2015-01-19 18:32 ` Doug Evans
2015-01-31 21:37 ` Eli Zaretskii [this message]
2015-02-03 17:52 ` Pedro Alves
2015-02-03 18:47 ` Eli Zaretskii
2015-02-04 11:55 ` Pedro Alves
2015-02-04 12:27 ` Pedro Alves
2015-02-04 15:39 ` Eli Zaretskii
2015-02-04 15:38 ` Eli Zaretskii
2015-01-07 15:18 ` Pedro Alves
2015-01-07 17:57 ` Eli Zaretskii
2015-01-07 18:09 ` Doug Evans
2015-01-07 18:34 ` Eli Zaretskii
2015-01-07 19:16 ` Doug Evans
2015-01-07 19:32 ` Eli Zaretskii
2015-01-07 22:30 ` Pedro Alves
2015-01-19 17:52 ` Eli Zaretskii
2015-01-07 18:00 ` Doug Evans
2015-01-07 18:12 ` Doug Evans
2015-01-07 18:34 ` Eli Zaretskii
2015-01-07 18:21 ` Eli Zaretskii
2015-01-07 18:56 ` Doug Evans
2015-01-07 19:11 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83vbjnjpfb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).