From: Eli Zaretskii <eliz@gnu.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: brobecker@adacore.com, yao@codesourcery.com,
gdb-patches@sourceware.org, ktietz@redhat.com
Subject: Re: [patch] compile: Fix MinGW build [Re: [mingw rfc] Add mkdtemp to gdb/gnulib/]
Date: Tue, 16 Dec 2014 03:37:00 -0000 [thread overview]
Message-ID: <83vblcw9hw.fsf@gnu.org> (raw)
In-Reply-To: <20141215222801.GA28138@host2.jankratochvil.net>
> Date: Mon, 15 Dec 2014 23:28:01 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: brobecker@adacore.com, yao@codesourcery.com, gdb-patches@sourceware.org,
> ktietz@redhat.com
>
> Even if it managed to load libcc1.so (it needs host-dependent name libcc1.dll)
> then it would soon end up at least on:
>
> default_infcall_mmap:
> error (_("This target does not support inferior memory allocation by mmap."));
>
> As currently there is only:
>
> linux-tdep.c:
> set_gdbarch_infcall_mmap (gdbarch, linux_infcall_mmap);
Why is mmap needed here?
> OK for check-in?
>
>
> Thanks,
> Jan
> gdb/ChangeLog
> 2014-12-15 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Fix MinGW compilation.
> * compile/compile.c (get_compile_file_tempdir): Call error on _WIN32.
>
> --- ./gdb/compile/compile.c 2014-12-14 02:48:38.000000000 +0100
> +++ ./gdb/compile/compile.c 2014-12-15 23:21:28.788716340 +0100
> @@ -191,7 +191,11 @@ get_compile_file_tempdir (void)
>
> strcpy (tname, TEMPLATE);
> #undef TEMPLATE
> +#ifdef _WIN32
> + error (_("mkdtemp needs to be implemented for MS-Windows hosts"));
> +#else
> tempdir_name = mkdtemp (tname);
> +#endif
> if (tempdir_name == NULL)
> perror_with_name (_("Could not make temporary directory"));
I think _WIN32 will catch Cygwin as well, which is not what you want.
Why not just check HAVE_MKDTEMP?
next prev parent reply other threads:[~2014-12-16 3:37 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-23 19:27 [PATCH v4 00/14] let gdb reuse gcc's C compiler Jan Kratochvil
2014-11-23 19:27 ` [PATCH v4 02/14] add gcc/gdb interface files Jan Kratochvil
2014-11-23 19:27 ` [PATCH v4 03/14] add some missing ops to DWARF assembler Jan Kratochvil
2014-11-23 19:27 ` [PATCH v4 01/14] introduce ui_file_write_for_put Jan Kratochvil
2014-11-23 19:27 ` [PATCH v4 04/14] add make_unqualified_type Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 09/14] split dwarf2_fetch_cfa_info from dwarf2_compile_expr_to_ax Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 06/14] add infcall_mmap and gcc_target_options gdbarch methods Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 13/14] add s390_gcc_target_options Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 12/14] add linux_infcall_mmap Jan Kratochvil
2014-12-15 12:41 ` Ulrich Weigand
2014-12-15 13:49 ` Yao Qi
2014-12-15 16:48 ` Jan Kratochvil
2014-12-16 5:27 ` Yao Qi
2014-11-23 19:28 ` [PATCH v4 11/14] export dwarf2_reg_to_regnum_or_error Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 05/14] add dummy frame destructor Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 08/14] introduce call_function_by_hand_dummy Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 10/14] make dwarf_expr_frame_base_1 public Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 07/14] add gnu_triplet_regexp gdbarch method Jan Kratochvil
2014-11-23 19:29 ` [PATCH v4 14/14] the "compile" command Jan Kratochvil
2014-12-14 6:05 ` Yao Qi
2014-12-14 7:53 ` Jan Kratochvil
2014-12-14 8:54 ` Yao Qi
2014-12-14 18:24 ` [mingw rfc] Add mkdtemp to gdb/gnulib/ [Re: [PATCH v4 14/14] the "compile" command] Jan Kratochvil
2014-12-15 3:16 ` Yao Qi
2014-12-15 12:44 ` Joel Brobecker
2014-12-15 13:11 ` Kai Tietz
2014-12-15 13:24 ` Yao Qi
2014-12-15 17:12 ` Jan Kratochvil
2014-12-15 17:48 ` Eli Zaretskii
2014-12-15 18:14 ` Joel Brobecker
2014-12-15 18:21 ` Jan Kratochvil
2014-12-15 18:35 ` Joel Brobecker
2014-12-15 18:40 ` Jan Kratochvil
2014-12-15 18:57 ` Eli Zaretskii
2014-12-15 22:28 ` [patch] compile: Fix MinGW build [Re: [mingw rfc] Add mkdtemp to gdb/gnulib/] Jan Kratochvil
2014-12-15 22:56 ` Jan Kratochvil
2014-12-16 3:40 ` Eli Zaretskii
2014-12-16 9:04 ` Kai Tietz
2014-12-17 21:02 ` [patch] compile: rm -rf -> ftw()+rmdir()+unlink() [Re: [patch] compile: Fix MinGW build] Jan Kratochvil
2014-12-17 22:07 ` Steve Ellcey
2014-12-17 22:42 ` Pedro Alves
2014-12-18 18:14 ` Jan Kratochvil
2014-12-18 18:24 ` Pedro Alves
2014-12-18 18:41 ` Jan Kratochvil
2014-12-18 19:07 ` Pedro Alves
2014-12-18 21:05 ` Jan Kratochvil
2014-12-18 21:11 ` Eli Zaretskii
2014-12-18 21:24 ` Jan Kratochvil
2014-12-18 22:18 ` Sergio Durigan Junior
2014-12-18 23:06 ` Pedro Alves
2014-12-19 0:12 ` Jan Kratochvil
2014-12-19 10:48 ` Pedro Alves
2014-12-19 8:24 ` Eli Zaretskii
2014-12-19 12:59 ` Joel Brobecker
2014-12-18 20:26 ` Eli Zaretskii
2014-12-18 5:38 ` Yao Qi
2014-12-18 17:23 ` Eli Zaretskii
2014-12-18 17:31 ` Jan Kratochvil
2014-12-18 17:40 ` Eli Zaretskii
2014-12-18 20:15 ` Kai Tietz
2014-12-18 20:47 ` Eli Zaretskii
2014-12-18 20:55 ` Kai Tietz
2014-12-18 23:47 ` Pedro Alves
2014-12-19 9:28 ` Kai Tietz
2014-12-19 19:25 ` Jan Kratochvil
2014-12-19 20:55 ` Jan Kratochvil
2014-12-20 12:26 ` Joel Brobecker
2014-12-18 20:56 ` Sergio Durigan Junior
2014-12-17 17:30 ` [patch] compile: Fix MinGW build [Re: [mingw rfc] Add mkdtemp to gdb/gnulib/] Steve Ellcey
2014-12-16 3:37 ` Eli Zaretskii [this message]
2014-12-16 9:06 ` Kai Tietz
2014-12-17 19:18 ` Jan Kratochvil
2014-12-17 19:31 ` Eli Zaretskii
2014-12-17 19:37 ` Jan Kratochvil
2014-12-17 20:34 ` Pedro Alves
2014-12-18 17:22 ` Eli Zaretskii
2014-12-18 18:00 ` Pedro Alves
2014-12-16 12:40 ` Pierre Muller
2014-12-17 18:21 ` Jan Kratochvil
2014-12-17 1:22 ` Yao Qi
2014-12-17 10:57 ` Pedro Alves
2014-12-17 11:40 ` Yao Qi
2014-12-17 11:43 ` Pedro Alves
2014-12-17 11:56 ` Yao Qi
2014-12-17 19:15 ` Jan Kratochvil
2014-12-17 11:16 ` Pedro Alves
2014-12-17 18:17 ` [patchv2] " Jan Kratochvil
2014-12-17 18:33 ` Pedro Alves
2014-12-17 19:12 ` [commit] " Jan Kratochvil
2014-12-05 18:29 ` [patch 15/14] GDB/GCC compile function pointers [Re: [PATCH v4 00/14] let gdb reuse gcc's C compiler] Jan Kratochvil
2014-12-12 21:51 ` obsolete: " Jan Kratochvil
2014-12-12 14:40 ` [PATCH v4 00/14] let gdb reuse gcc's C compiler Pedro Alves
2014-12-12 21:46 ` [commit all 14 parts] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83vblcw9hw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=ktietz@redhat.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).