From: Eli Zaretskii <eliz@gnu.org>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Add options to skip unavailable locals
Date: Wed, 03 Jul 2013 19:22:00 -0000 [thread overview]
Message-ID: <83vc4ra1ps.fsf@gnu.org> (raw)
In-Reply-To: <1372816106-15942-3-git-send-email-yao@codesourcery.com>
> From: Yao Qi <yao@codesourcery.com>
> Date: Wed, 3 Jul 2013 09:48:26 +0800
>
> This is the patch to add new option '--skip-unavailable' to MI
> commands '-stack-list-{locals, arguments, variables}'. This patch
> extends list_args_or_locals to add a new parameter 'skip_unavailable',
> and don't list locals or arguments if values are unavailable and
> 'skip_unavailable' is true.
Thanks.
> + ** The commands -stack-list-locals, -stack-list-arguments and
> + -stack-list-variables now accept an optional "--skip-unavailable"
> + option. When used, only the available locals or arguments are
> + displayed.
"optional option" doesn't sound right. I think dropping the
"optional" part is all you need.
> +If the @code{--skip-unavailable} option is specified, arguments that
> +have not been available are not listed. Partially available objects
^^^^^^^^^^^^^^^^^^^^^^^
"are not available".
And why "objects" instead of "arguments"?
> +If the @code{--skip-unavailable} option is specified, local variables
> +that have not been available are not listed. Partially available
> +objects are still displayed, however.
Likewise, on both accounts. There are other places with the same
problems.
> +If the @code{--skip-unavailable} option is specified, then, local
^^^^^
This "then" and the comma after it should be deleted.
OK with those changes.
next prev parent reply other threads:[~2013-07-03 19:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 1:48 [PATCH 0/2] New option --skip-unavailable to -stack-list-XXX commands Yao Qi
2013-07-03 1:48 ` [PATCH 2/2] Add options to skip unavailable locals Yao Qi
2013-07-03 4:14 ` asmwarrior
2013-07-03 5:21 ` Yao Qi
2013-07-03 19:22 ` Eli Zaretskii [this message]
2013-07-22 1:38 ` Yao Qi
2013-08-01 12:33 ` Pedro Alves
2013-08-01 13:59 ` Yao Qi
2013-08-01 14:47 ` Pedro Alves
2013-08-25 3:43 ` [PATCH 0/2 v2] " Yao Qi
2013-08-25 3:43 ` [PATCH 1/2] Use mi_getopt_silent Yao Qi
2013-08-26 8:58 ` Agovic, Sanimir
2013-08-26 10:18 ` Yao Qi
2013-08-26 16:01 ` Pedro Alves
2013-08-26 16:22 ` Pedro Alves
2013-08-27 3:30 ` Yao Qi
2013-08-27 11:43 ` Pedro Alves
2013-08-25 3:43 ` [PATCH 2/2] Add options to skip unavailable locals Yao Qi
2013-08-26 16:40 ` Pedro Alves
2013-08-27 5:22 ` Yao Qi
2013-07-03 1:48 ` [PATCH 1/2] Use mi_getopt in mi_cmd_stack_list_locals and mi_cmd_stack_list_variables Yao Qi
2013-07-29 18:17 ` Pedro Alves
2013-07-31 7:01 ` Yao Qi
2013-07-31 12:23 ` Pedro Alves
2013-08-01 6:45 ` Yao Qi
2013-07-29 9:33 ` [ping]: [PATCH 0/2] New option --skip-unavailable to -stack-list-XXX commands Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83vc4ra1ps.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).