From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32504 invoked by alias); 6 Oct 2010 21:04:22 -0000 Received: (qmail 32496 invoked by uid 22791); 6 Oct 2010 21:04:22 -0000 X-SWARE-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_DUL,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Oct 2010 21:04:16 +0000 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0L9V00B00ZT3JE00@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Wed, 06 Oct 2010 23:04:07 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.148.82]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L9V00BWWZUTAM90@a-mtaout23.012.net.il>; Wed, 06 Oct 2010 23:04:07 +0200 (IST) Date: Wed, 06 Oct 2010 21:04:00 -0000 From: Eli Zaretskii Subject: Re: [RFA] New python module gdb.types In-reply-to: <20101006204434.DCD842461B2@ruffy.mtv.corp.google.com> To: dje@google.com (Doug Evans) Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83vd5fnicu.fsf@gnu.org> References: <20101006204434.DCD842461B2@ruffy.mtv.corp.google.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00086.txt.bz2 > Date: Wed, 6 Oct 2010 13:44:34 -0700 (PDT) > From: dje@google.com (Doug Evans) > > This patch adds a new python module to gdb, gdb.types. > It contains a small collection of utilities that I've been using. Thanks. > + ** Module gdb.types has been added. > + It contains a collection of utilities for working with gdb.Types objects: > + get_basic_type, has_field, make_enum_dict. This part is okay. > +@cindex Python modules Index entries should use lower-case letters only (to avoid problems with sorting them in certain locales). > +@item get_basic_type (@var{type}) > +Return @var{type} with const and volatile qualifiers, typedefs, > +and references stripped away. This is quite cryptic. I can understand what it means to remove const, volatile, etc. qualifiers (what about `static', btw?), but what does it mean to "strip" a typedef or a reference? At the very least please give a few examples, if this cannot be explained easily. > +@item make_enum_dict (@var{enum_type}) > +Return a dictionary made from @var{enum_type}. Same here: at the very least we should say what is a "dictionary" in this context.