From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id C071E385783F for ; Tue, 16 May 2023 15:02:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C071E385783F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pywBu-0001qs-Dp; Tue, 16 May 2023 11:02:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3zcBWowpr2KEpgHXpGtvG+iyo4g74bCp40sBZLUPsDk=; b=q0pE04bKLFaT YUestRm/j8v5lp4hgIUJS7Mb1LrcBhOyWynnp+i6zh/VuURDSMy0A3PSx5TM6ZJ6a93jqHrXAxEwN x+DZGUXgF6J4ck1/0rCMg3eiuXVLJm4H+rn2vNHNcuqMl1uzxUE/UyXrnD8mwT9v8fObmztCIybnW hpNIsKqunRlrQ330Xr4UEwxIpivMbG517VvAK8agrkqUlarwyhNdf4hTVSotxDtbbOkpE3BJLdGIB GszsVSI+9LFcrTIM9yPfbkrUgOjb3umg7YyZp+l5+9iuQ/7E1SxcxBYCZQdAS2yeF4pj88WW4S1UD 3yKzyBCDikCfPnpaWB/MBQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pywBt-0003F8-Qm; Tue, 16 May 2023 11:02:18 -0400 Date: Tue, 16 May 2023 18:02:26 +0300 Message-Id: <83wn18z5dp.fsf@gnu.org> From: Eli Zaretskii To: Tom de Vries Cc: gdb-patches@sourceware.org, tom@tromey.com In-Reply-To: <20230516084352.27225-4-tdevries@suse.de> (message from Tom de Vries via Gdb-patches on Tue, 16 May 2023 10:43:52 +0200) Subject: Re: [PATCH 3/3] [gdb/tui] Add set tui contents-highlight on/off References: <20230516084352.27225-1-tdevries@suse.de> <20230516084352.27225-4-tdevries@suse.de> X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: Tom Tromey > Date: Tue, 16 May 2023 10:43:52 +0200 > From: Tom de Vries via Gdb-patches > > TUI highlights various parts of TUI windows: > - highlighting of the current execution point in the assembly and source > windows, > - highlighting of changed registers in the register window. > > Add a new command "set tui contents-highlight on/off" that allows us to disable > this. > > The default is on, so there's no change in behaviour. > > Note that the highlighting in all three windows is shadowed by the ">" marker, > so we're not losing information by switching off the highlighting. > > Tested on x86_64-linux. > --- > gdb/doc/gdb.texinfo | 7 ++++ > gdb/testsuite/gdb.tui/source.exp | 59 ++++++++++++++++++++++++++++++++ > gdb/tui/tui-regs.c | 4 +-- > gdb/tui/tui-regs.h | 4 +-- > gdb/tui/tui-win.c | 39 +++++++++++++++++++++ > gdb/tui/tui-win.h | 4 +++ > gdb/tui/tui-winsource.c | 4 +-- > 7 files changed, 115 insertions(+), 6 deletions(-) > create mode 100644 gdb/testsuite/gdb.tui/source.exp The documentation part is OK, thanks. Reviewed-By: Eli Zaretskii