From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 8AB5C3858D38 for ; Tue, 11 Apr 2023 08:46:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8AB5C3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pm9eF-00029X-TJ; Tue, 11 Apr 2023 04:46:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GV/BtZtnznfwD1bBoRV/xfmuCV8MQOPoSGkWGrR2lnE=; b=GsBTKjZIm86i 6la2DIsd+XSfVx3iOW1DJQo5W+RmKNW6DxZtI65TruS8d1GZEoQi4eUbjjT7htoO+vF6OXwLU1fYQ MvvZPEymL+O60nEvLkyLX7o1ZeDsfVvL/MFuWsVi/yB9gCWMo6Mrtmq8sZlbtiFiIJ87RlYxSNnRQ sfd/GFAkeccpdmGmbu6URH9q2K8YCzZczdsfKHsjIRCm9fDO4ukg85LewdI+sAsgHbBd8cpGrNz7t Rst7/1w0zXbQVYXNJzWOQGztuGV40tIkOqlDH6R8vQkI0/ZdOASWgsOGo69/tPX2tZj7TCE/KcATk /Jni9iREewnrhJZcLRBlNA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pm9eF-0002OL-9i; Tue, 11 Apr 2023 04:46:43 -0400 Date: Tue, 11 Apr 2023 11:47:25 +0300 Message-Id: <83wn2iajqa.fsf@gnu.org> From: Eli Zaretskii To: Tom de Vries Cc: gdb-patches@sourceware.org In-Reply-To: <20230411082332.25052-1-tdevries@suse.de> (message from Tom de Vries via Gdb-patches on Tue, 11 Apr 2023 10:23:30 +0200) Subject: Re: [PATCH 1/3] [gdb/tui] Add maint set/show tui-left-margin-verbose References: <20230411082332.25052-1-tdevries@suse.de> X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: Tom Tromey > Date: Tue, 11 Apr 2023 10:23:30 +0200 > From: Tom de Vries via Gdb-patches > > gdb/doc/gdb.texinfo | 8 ++++++++ > gdb/tui/tui-source.c | 5 ++++- > gdb/tui/tui-win.c | 16 ++++++++++++++++ > gdb/tui/tui-win.h | 3 +++ > gdb/tui/tui-winsource.c | 7 ++++++- > 5 files changed, 37 insertions(+), 2 deletions(-) > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 2d5358a792b..bb96ddb2d52 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -41242,6 +41242,14 @@ has been resized. This setting is intended for use by the test suite, > where it would otherwise be difficult to determine when a resize and > refresh has been completed. > > +@kindex maint set tui-left-margin-verbose > +@kindex maint show tui-left-margin-verbose > +@item maint set tui-left-margin-verbose > +@item maint show tui-left-margin-verbose > +Control whether the left margin of the TUI source and disassembly windows > +uses @samp{_} and @samp{0} at locations where otherwise there would be a > +space. The default is @code{off}, which means spaces are used. This is okay, but I suggest adding a sentence explaining the rationale for using this command. Otherwise, its purpose is unclear, not without reading the description you included in the commit log. Thanks. Reviewed-By: Eli Zaretskii